[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-panel-devel
Subject: Re: Re: Fwd: back developing [KRunner Bookmarks for chrome]
From: Marco Gulino <marco.gulino () gmail ! com>
Date: 2012-07-20 17:01:03
Message-ID: CAGe7n9X6WDu+hm=hAvGCot4HOp2hEHDFrQMLF7AhvcDahaANkQ () mail ! gmail ! com
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
Ok, pushed
branch is plasma/bookmarksrunner-chrome-gulino (based on 4.9, will forward
port to master after the review).
Basically i extracted major responsibilities into separate classes, created
an interface Browser, and added Chrome/Chromium support via QJson (should
it be an optional dependency?).
It "looks" like it's a lot more complex, but actually there's much less
code (i could delete many duplicated methods, unneeded ifs, and so on).
I also added unit test, as i previously stated.
What's missing: favicons.
Both firefox and chrome use sqlite and store icons in a blob, but it looks
like a hack is needed, since i cant load blob icons directly into a pixmap.
I tried using temporary files, and it works, but it sounds like a dirty
approach, kinda study it a little more before pushing.
Thanks
Marco
On Fri, Jul 20, 2012 at 1:59 PM, Marco Gulino <marco.gulino@gmail.com>wrote:
> Thank you, but this proxy is kinda too much restrictive, i can use https,
> but ssh on https port doesn't seem to work.
> Anyway, not a big deal... in a few hours i'll be on holiday for a whole
> month, no proxy or firewalls in the way :)
>
>
> On Fri, Jul 20, 2012 at 1:11 PM, Ben Cooksley <bcooksley@kde.org> wrote:
>>
>> In case it helps, KDE repositories are accessible over port 443
>> (usually used for https - used by SSH by us however) which most
>> restrictive firewalls and proxies have no problems in passing through.
>>
>
[Attachment #5 (text/html)]
Ok, pushed<div>branch is plasma/bookmarksrunner-chrome-gulino (based on 4.9, will \
forward port to master after the review).</div><div><br></div><div>Basically i \
extracted major responsibilities into separate classes, created an interface Browser, \
and added Chrome/Chromium support via QJson (should it be an optional \
dependency?).</div>
<div>It "looks" like it's a lot more complex, but actually there's \
much less code (i could delete many duplicated methods, unneeded ifs, and so \
on).</div><div>I also added unit test, as i previously stated.</div>
<div><br></div><div><br></div><div>What's missing: favicons.</div><div>Both \
firefox and chrome use sqlite and store icons in a blob, but it looks like a hack is \
needed, since i cant load blob icons directly into a pixmap.</div>
<div><br></div><div>I tried using temporary files, and it works, but it sounds like a \
dirty approach, kinda study it a little more before \
pushing.</div><div><br></div><div>Thanks</div><div>Marco</div><div><br><div \
class="gmail_quote">
On Fri, Jul 20, 2012 at 1:59 PM, Marco Gulino <span dir="ltr"><<a \
href="mailto:marco.gulino@gmail.com" \
target="_blank">marco.gulino@gmail.com</a>></span> wrote:<br><blockquote \
class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc \
solid;padding-left:1ex">
Thank you, but this proxy is kinda too much restrictive, i can use https, but ssh on \
https port doesn't seem to work.<div><div>Anyway, not a big deal... in a few \
hours i'll be on holiday for a whole month, no proxy or firewalls in the way \
:)<div class="im">
<br>
<br><div class="gmail_quote">On Fri, Jul 20, 2012 at 1:11 PM, Ben Cooksley <span \
dir="ltr"><<a href="mailto:bcooksley@kde.org" \
target="_blank">bcooksley@kde.org</a>></span> wrote:<blockquote \
class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc \
solid;padding-left:1ex">
In case it helps, KDE repositories are accessible over port 443<br>
(usually used for https - used by SSH by us however) which most<br>
restrictive firewalls and proxies have no problems in passing \
through.<br></blockquote></div></div></div></div> </blockquote></div><br></div>
_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic