'Re: Review Request: kickoff-qml: TabBar button width'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    Re: Review Request: kickoff-qml: TabBar button width
From:       "Marco Martin" <notmart () gmail ! com>
Date:       2012-07-19 9:04:06
Message-ID: 20120719090406.6126.46467 () vidsolbach ! de
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105405/#review16103
-----------------------------------------------------------

thanks, wouldn;t have remembered ;)

the changes seems good, but i'm not sure about giving kickoff a copy of the=
 tabbar.

any reason this is not proposed as a patch for the tabbar component itself?

- Marco Martin

On July 1, 2012, 8:42 p.m., Greg T wrote:
> =

> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/105405/
> -----------------------------------------------------------
> =

> (Updated July 1, 2012, 8:42 p.m.)
> =

> =

> Review request for Plasma, Marco Martin and Martin Gr=C3=A4=C3=9Flin.
> =

> =

> Description
> -------
> =

> Heda,
> This patch addresses the layout of the tab bar. The tab buttons are now s=
ized depending of their text width.
> =

> I just copied the tabbar code from kde-runtime and exchanged taskbarLayou=
t. My main question is: Can I do this more elegantly without copying TabBar=
.qml?
> =

> =

> Diffs
> -----
> =

>   plasma/desktop/applets/kickoff/package/contents/ui/KickoffTabBar.qml PR=
E-CREATION =

>   plasma/desktop/applets/kickoff/package/contents/ui/Private/TabBarLayout=
.qml PRE-CREATION =

>   plasma/desktop/applets/kickoff/package/contents/ui/kickoff.qml 4d53208 =

> =

> Diff: http://git.reviewboard.kde.org/r/105405/diff/
> =

> =

> Testing
> -------
> =

> =

> Thanks,
> =

> Greg T
> =

>

[Attachment #5 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="http://git.reviewboard.kde.org/r/105405/">http://git.reviewboard.kde.org/r/105405/</a>
  </td>
    </tr>
   </table>
   <br />

 <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">thanks, wouldn;t have \
remembered ;)

the changes seems good, but i&#39;m not sure about giving kickoff a copy of the \
tabbar.

any reason this is not proposed as a patch for the tabbar component itself?</pre>
 <br />

<p>- Marco</p>

<br />
<p>On July 1st, 2012, 8:42 p.m., Greg T wrote:</p>

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;">  <tr>
  <td>

<div>Review request for Plasma, Marco Martin and Martin Gräßlin.</div>
<div>By Greg T.</div>

<p style="color: grey;"><i>Updated July 1, 2012, 8:42 p.m.</i></p>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Heda, This patch addresses the layout of the tab bar. The tab buttons \
are now sized depending of their text width.

I just copied the tabbar code from kde-runtime and exchanged taskbarLayout. My main \
question is: Can I do this more elegantly without copying TabBar.qml?</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>plasma/desktop/applets/kickoff/package/contents/ui/KickoffTabBar.qml <span \
style="color: grey">(PRE-CREATION)</span></li>

 <li>plasma/desktop/applets/kickoff/package/contents/ui/Private/TabBarLayout.qml \
<span style="color: grey">(PRE-CREATION)</span></li>

 <li>plasma/desktop/applets/kickoff/package/contents/ui/kickoff.qml <span \
style="color: grey">(4d53208)</span></li>

</ul>

<p><a href="http://git.reviewboard.kde.org/r/105405/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[prev in list] [next in list] [prev in thread] [next in thread] 