'Re: Review Request: added mouse middle button support to scrollbar qml'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    Re: Review Request: added mouse middle button support to scrollbar qml
From:       "Commit Hook" <null () kde ! org>
Date:       2012-07-17 11:58:53
Message-ID: 20120717115853.2557.44004 () vidsolbach ! de
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105576/#review16009
-----------------------------------------------------------

This review has been submitted with commit 217c8c0ba2de58a8c0691e4b3dec45023a16e908 \
by Reza Shah to branch KDE/4.9.

- Commit Hook

On July 17, 2012, 11:01 a.m., Reza Shah wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/105576/
> -----------------------------------------------------------
> 
> (Updated July 17, 2012, 11:01 a.m.)
> 
> 
> Review request for Plasma and Marco Martin.
> 
> 
> Description
> -------
> 
> trying to fix https://bugs.kde.org/show_bug.cgi?id=272934
> by adding mouse middle button click support to scrollbar qml.
> 
> if accepted i will push to KDE/4.9 too.
> 
> 
> This addresses bug 272934.
> http://bugs.kde.org/show_bug.cgi?id=272934
> 
> 
> Diffs
> -----
> 
> plasma/declarativeimports/plasmacomponents/qml/private/ScrollBarDelegate.qml \
> 02a869e  
> Diff: http://git.reviewboard.kde.org/r/105576/diff/
> 
> 
> Testing
> -------
> 
> tested against widget explorer in master
> 
> 
> Thanks,
> 
> Reza Shah
> 
> 

[Attachment #5 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="http://git.reviewboard.kde.org/r/105576/">http://git.reviewboard.kde.org/r/105576/</a>
  </td>
    </tr>
   </table>
   <br />

 <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This review has been \
submitted with commit 217c8c0ba2de58a8c0691e4b3dec45023a16e908 by Reza Shah to branch \
KDE/4.9.</pre>  <br />

<p>- Commit</p>

<br />
<p>On July 17th, 2012, 11:01 a.m., Reza Shah wrote:</p>

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;">  <tr>
  <td>

<div>Review request for Plasma and Marco Martin.</div>
<div>By Reza Shah.</div>

<p style="color: grey;"><i>Updated July 17, 2012, 11:01 a.m.</i></p>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">trying to fix https://bugs.kde.org/show_bug.cgi?id=272934 by adding \
mouse middle button click support to scrollbar qml.

if accepted i will push to KDE/4.9 too.</pre>
  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">tested against widget explorer in master</pre>  </td>
 </tr>
</table>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>

 <a href="http://bugs.kde.org/show_bug.cgi?id=272934">272934</a>

</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>plasma/declarativeimports/plasmacomponents/qml/private/ScrollBarDelegate.qml \
<span style="color: grey">(02a869e)</span></li>

</ul>

<p><a href="http://git.reviewboard.kde.org/r/105576/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[prev in list] [next in list] [prev in thread] [next in thread] 