[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-panel-devel
Subject: Re: Review Request: Fix the wrong usage of "Keywords" in one .dekstop file
From: "Commit Hook" <null () kde ! org>
Date: 2012-07-15 13:45:00
Message-ID: 20120715134500.16229.55261 () vidsolbach ! de
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105555/#review15883
-----------------------------------------------------------
This review has been submitted with commit acfc291e795fa4b087da5584a6b85013=
97a160a5 by Jekyll Wu to branch master.
- Commit Hook
On July 13, 2012, 2:49 p.m., Jekyll Wu wrote:
> =
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/105555/
> -----------------------------------------------------------
> =
> (Updated July 13, 2012, 2:49 p.m.)
> =
> =
> Review request for Plasma.
> =
> =
> Description
> -------
> =
> It is similar to review 105553.
> =
> According to the FDO specification[1][2], the type of "Keywords" is "loca=
lestring(s)", where multiple values are separated by a semicolon. =
> =
> The affected two .desktop files use comma instead of semicolon to separat=
e multiple values. That seems to be the expected behavior for "X-KDE-Keywor=
ds", but not for "Keywords".
> =
> The patch simply uses semicolon and adds the trailing semicolon.
> =
> =
> [1] http://standards.freedesktop.org/desktop-entry-spec/latest/ar01s05.ht=
ml
> [2] http://standards.freedesktop.org/desktop-entry-spec/latest/ar01s03.ht=
ml
> =
> =
> Diffs
> -----
> =
> applets/microblog/plasma-applet-microblog.desktop b8d3864 =
> =
> Diff: http://git.reviewboard.kde.org/r/105555/diff/
> =
> =
> Testing
> -------
> =
> =
> Thanks,
> =
> Jekyll Wu
> =
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/105555/">http://git.reviewboard.kde.org/r/105555/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This review has been \
submitted with commit acfc291e795fa4b087da5584a6b8501397a160a5 by Jekyll Wu to branch \
master.</pre> <br />
<p>- Commit</p>
<br />
<p>On July 13th, 2012, 2:49 p.m., Jekyll Wu wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for Plasma.</div>
<div>By Jekyll Wu.</div>
<p style="color: grey;"><i>Updated July 13, 2012, 2:49 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">It is similar to review 105553.
According to the FDO specification[1][2], the type of "Keywords" is \
"localestring(s)", where multiple values are separated by a semicolon.
The affected two .desktop files use comma instead of semicolon to separate multiple \
values. That seems to be the expected behavior for "X-KDE-Keywords", but \
not for "Keywords".
The patch simply uses semicolon and adds the trailing semicolon.
[1] http://standards.freedesktop.org/desktop-entry-spec/latest/ar01s05.html
[2] http://standards.freedesktop.org/desktop-entry-spec/latest/ar01s03.html
</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>applets/microblog/plasma-applet-microblog.desktop <span style="color: \
grey">(b8d3864)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/105555/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic