'Re: Review Request: fixed calendar plasmoid configuration not saved'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    Re: Review Request: fixed calendar plasmoid configuration not saved
From:       "Commit Hook" <null () kde ! org>
Date:       2012-07-14 20:49:42
Message-ID: 20120714204942.5458.97444 () vidsolbach ! de
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105569/#review15861
-----------------------------------------------------------

This review has been submitted with commit 5d3fc528e3b895c098069871f6106fe71d53af21 \
by Reza Shah to branch master.

- Commit Hook

On July 14, 2012, 11:49 a.m., Reza Shah wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/105569/
> -----------------------------------------------------------
> 
> (Updated July 14, 2012, 11:49 a.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Description
> -------
> 
> This patch tries to fix bug which caused calendar configuration is not saved.
> as mention in this bug: https://bugs.kde.org/show_bug.cgi?id=302958
> 
> Inside this function
> void Calendar::applyConfiguration(KConfigGroup cg)
> {
> const bool details = isDisplayingDateDetails();
> calendarTable()->applyConfiguration(cg);
> if (details != isDisplayingDateDetails()) {
> d->updatePreferredSize();
> }
> }
> 
> Should i remove calendarTable()->applyConfiguration(cg); too?
> Seems it redundant with calendarTable()->configAccepted(cg);
> 
> 
> This addresses bug 302958.
> http://bugs.kde.org/show_bug.cgi?id=302958
> 
> 
> Diffs
> -----
> 
> libs/plasmaclock/calendar.cpp e2b3b41 
> 
> Diff: http://git.reviewboard.kde.org/r/105569/diff/
> 
> 
> Testing
> -------
> 
> against master
> 
> 
> Thanks,
> 
> Reza Shah
> 
> 

[Attachment #5 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="http://git.reviewboard.kde.org/r/105569/">http://git.reviewboard.kde.org/r/105569/</a>
  </td>
    </tr>
   </table>
   <br />

 <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This review has been \
submitted with commit 5d3fc528e3b895c098069871f6106fe71d53af21 by Reza Shah to branch \
master.</pre>  <br />

<p>- Commit</p>

<br />
<p>On July 14th, 2012, 11:49 a.m., Reza Shah wrote:</p>

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;">  <tr>
  <td>

<div>Review request for Plasma.</div>
<div>By Reza Shah.</div>

<p style="color: grey;"><i>Updated July 14, 2012, 11:49 a.m.</i></p>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">This patch tries to fix bug which caused calendar configuration is not \
saved. as mention in this bug: https://bugs.kde.org/show_bug.cgi?id=302958

Inside this function
void Calendar::applyConfiguration(KConfigGroup cg)
{
    const bool details = isDisplayingDateDetails();
    calendarTable()-&gt;applyConfiguration(cg);
    if (details != isDisplayingDateDetails()) {
        d-&gt;updatePreferredSize();
    }
}

Should i remove calendarTable()-&gt;applyConfiguration(cg); too?
Seems it redundant with calendarTable()-&gt;configAccepted(cg);</pre>
  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">against master</pre>  </td>
 </tr>
</table>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>

 <a href="http://bugs.kde.org/show_bug.cgi?id=302958">302958</a>

</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>libs/plasmaclock/calendar.cpp <span style="color: grey">(e2b3b41)</span></li>

</ul>

<p><a href="http://git.reviewboard.kde.org/r/105569/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[prev in list] [next in list] [prev in thread] [next in thread] 