[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-panel-devel
Subject: Review Request: minimize listview item weird placement in widget explorer
From: "Reza Shah" <rshah0385 () kireihana ! com>
Date: 2012-07-13 5:11:58
Message-ID: 20120713051158.32174.66235 () vidsolbach ! de
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105544/
-----------------------------------------------------------
Review request for Plasma and Marco Martin.
Description
-------
Background:
There is a bug in widget explorer regarding item placement in listview, whi=
ch give bad visual placement.
Seems there is bug in qml listview. This patch tries to minimize the bad vi=
sual effect.
You can try to reproduce this by doing some searching using certain keyword=
to display list of plasmoid with combination of wheel scrolling, =
like below:
- use 'dev'
- use 'de'
- try wheel scrolling
Marco, after several trying, i think this patch has less bug while preservi=
ng little animation.
Diffs
-----
libs/plasmagenericshell/widgetsexplorer/kcategorizeditemsviewmodels.cpp 5=
00e6ff =
libs/plasmagenericshell/widgetsexplorer/package/contents/ui/AppletDelegat=
e.qml 98a7560 =
Diff: http://git.reviewboard.kde.org/r/105544/diff/
Testing
-------
tested against master
Thanks,
Reza Shah
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/105544/">http://git.reviewboard.kde.org/r/105544/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for Plasma and Marco Martin.</div>
<div>By Reza Shah.</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Background: There is a bug in widget explorer regarding item placement \
in listview, which give bad visual placement. Seems there is bug in qml listview. \
This patch tries to minimize the bad visual effect.
You can try to reproduce this by doing some searching using certain keyword to \
display list of plasmoid with combination of wheel scrolling, like below:
- use 'dev'
- use 'de'
- try wheel scrolling
Marco, after several trying, i think this patch has less bug while preserving little \
animation.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">tested against master</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>libs/plasmagenericshell/widgetsexplorer/kcategorizeditemsviewmodels.cpp <span \
style="color: grey">(500e6ff)</span></li>
<li>libs/plasmagenericshell/widgetsexplorer/package/contents/ui/AppletDelegate.qml \
<span style="color: grey">(98a7560)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/105544/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic