[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-panel-devel
Subject: Re: Review Request: add little margin to tooltip position
From: "Marco Martin" <notmart () gmail ! com>
Date: 2012-07-12 9:17:35
Message-ID: 20120712091735.15782.30297 () vidsolbach ! de
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105520/#review15718
-----------------------------------------------------------
Ship it!
the code of the "real" tooltips is completely different, is not done by the=
Dialog class.
now, try to update kdelibs and kde-workspace, i attempted to solve the prob=
lem in a slightly different way.
if a Dialog has Qt.toolTip among the window flags it shouldn't cut the bord=
ers anymore.
if bad countereffects will be encountered we can still fall back to this way
- Marco Martin
On July 12, 2012, 2:55 a.m., Reza Shah wrote:
> =
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/105520/
> -----------------------------------------------------------
> =
> (Updated July 12, 2012, 2:55 a.m.)
> =
> =
> Review request for Plasma and Marco Martin.
> =
> =
> Description
> -------
> =
> In current widget explorer, the tooltip for leftmost item is clipped, =
> this makes the appearance of tooltip and text inside it not properly disp=
layed.
> =
> The margin value is hardcoded, i like to have the same margin as the tool=
tip of kickoff plasmoid when placed at leftmost of the screen.
> But not sure which file should i read to get kickoff tooltip value.
> =
> I will commit this to KDE/4.9 and master if accepted.
> =
> =
> Diffs
> -----
> =
> libs/plasmagenericshell/widgetsexplorer/widgetexplorer.cpp 2651371 =
> =
> Diff: http://git.reviewboard.kde.org/r/105520/diff/
> =
> =
> Testing
> -------
> =
> tested againts master.
> =
> =
> Thanks,
> =
> Reza Shah
> =
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/105520/">http://git.reviewboard.kde.org/r/105520/</a>
</td>
</tr>
</table>
<br />
<p>Ship it!</p>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">the code of the \
"real" tooltips is completely different, is not done by the Dialog class.
now, try to update kdelibs and kde-workspace, i attempted to solve the problem in a \
slightly different way. if a Dialog has Qt.toolTip among the window flags it \
shouldn't cut the borders anymore. if bad countereffects will be encountered we \
can still fall back to this way</pre> <br />
<p>- Marco</p>
<br />
<p>On July 12th, 2012, 2:55 a.m., Reza Shah wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for Plasma and Marco Martin.</div>
<div>By Reza Shah.</div>
<p style="color: grey;"><i>Updated July 12, 2012, 2:55 a.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">In current widget explorer, the tooltip for leftmost item is clipped, \
this makes the appearance of tooltip and text inside it not properly displayed.
The margin value is hardcoded, i like to have the same margin as the tooltip of \
kickoff plasmoid when placed at leftmost of the screen. But not sure which file \
should i read to get kickoff tooltip value.
I will commit this to KDE/4.9 and master if accepted.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">tested againts master.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>libs/plasmagenericshell/widgetsexplorer/widgetexplorer.cpp <span style="color: \
grey">(2651371)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/105520/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic