'Re: Review Request: Fix position of widget explorer tooltip'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    Re: Review Request: Fix position of widget explorer tooltip
From:       "Commit Hook" <null () kde ! org>
Date:       2012-07-06 11:38:19
Message-ID: 20120706113819.13899.75262 () vidsolbach ! de
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105447/#review15454
-----------------------------------------------------------

This review has been submitted with commit 0df8824c65225b9475cd3d4c44d2d73b=
ed0609a9 by Aur=C3=A9lien G=C3=A2teau to branch master.

- Commit Hook

On July 5, 2012, 9:05 a.m., Aur=C3=A9lien G=C3=A2teau wrote:
> =

> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/105447/
> -----------------------------------------------------------
> =

> (Updated July 5, 2012, 9:05 a.m.)
> =

> =

> Review request for Plasma, KDE Usability and Marco Martin.
> =

> =

> Description
> -------
> =

> When the widget explorer is oriented vertically, applet tooltips shows on=
 top of other applets instead of showing on the right or on the left. This =
patch fixes it in a not-too intrusive way (original patch affected kdelibs =
and kde-runtime as well). If possible I would like this patch to be applied=
 to the KDE/4.9 branch as well.
> =

> =

> Diffs
> -----
> =

>   libs/plasmagenericshell/widgetsexplorer/package/contents/ui/main.qml cc=
84e6c =

>   libs/plasmagenericshell/widgetsexplorer/widgetexplorer.h 31308d2 =

>   libs/plasmagenericshell/widgetsexplorer/widgetexplorer.cpp 9b19f88 =

> =

> Diff: http://git.reviewboard.kde.org/r/105447/diff/
> =

> =

> Testing
> -------
> =

> Tested with panels on all edges.
> =

> =

> Screenshots
> -----------
> =

> before-after
>   http://git.reviewboard.kde.org/r/105447/s/616/
> =

> =

> Thanks,
> =

> Aur=C3=A9lien G=C3=A2teau
> =

>

[Attachment #5 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="http://git.reviewboard.kde.org/r/105447/">http://git.reviewboard.kde.org/r/105447/</a>
  </td>
    </tr>
   </table>
   <br />

 <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This review has been \
submitted with commit 0df8824c65225b9475cd3d4c44d2d73bed0609a9 by Aurélien Gâteau \
to branch master.</pre>  <br />

<p>- Commit</p>

<br />
<p>On July 5th, 2012, 9:05 a.m., Aurélien Gâteau wrote:</p>

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;">  <tr>
  <td>

<div>Review request for Plasma, KDE Usability and Marco Martin.</div>
<div>By Aurélien Gâteau.</div>

<p style="color: grey;"><i>Updated July 5, 2012, 9:05 a.m.</i></p>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">When the widget explorer is oriented vertically, applet tooltips shows \
on top of other applets instead of showing on the right or on the left. This patch \
fixes it in a not-too intrusive way (original patch affected kdelibs and kde-runtime \
as well). If possible I would like this patch to be applied to the KDE/4.9 branch as \
well.</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Tested with panels on all edges.</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>libs/plasmagenericshell/widgetsexplorer/package/contents/ui/main.qml <span \
style="color: grey">(cc84e6c)</span></li>

 <li>libs/plasmagenericshell/widgetsexplorer/widgetexplorer.h <span style="color: \
grey">(31308d2)</span></li>

 <li>libs/plasmagenericshell/widgetsexplorer/widgetexplorer.cpp <span style="color: \
grey">(9b19f88)</span></li>

</ul>

<p><a href="http://git.reviewboard.kde.org/r/105447/diff/" style="margin-left: \
3em;">View Diff</a></p>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Screenshots </h1>

<div>

 <a href="http://git.reviewboard.kde.org/r/105447/s/616/"><img \
src="http://git.reviewboard.kde.org/media/uploaded/images/2012/07/05/widget-explorer-tooltip_400x100.png" \
style="border: 1px black solid;" alt="before-after" /></a>

</div>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[prev in list] [next in list] [prev in thread] [next in thread] 