[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-panel-devel
Subject: Re: Review Request: DBus-interface for changing wallpapers
From: "Varun Herale" <varun.herale () gmail ! com>
Date: 2012-06-29 2:40:56
Message-ID: 20120629024056.27874.22050 () vidsolbach ! de
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
> On June 28, 2012, 4:48 p.m., Aaron J. Seigo wrote:
> > plasma/desktop/shell/plasmaapp.cpp, line 397
> > <http://git.reviewboard.kde.org/r/105319/diff/5/?file=70293#file70293line397>
> >
> > i would prefer it if the plugin name and mode were not exposed. the use case is \
> > "setting a wallpaper image" so let's implement that.
> > the main problem with being able to set the name and mode is that not only are \
> > most of the plugins optional (just asking for fun breakage) but also require \
> > configuration.
> > so i would recommend a rather simpler setWallpaperImage(const QString &url).
> >
> > it should probably do similar to what the drag and drop support does and if the \
> > url is not local then try to fetch it using KIO.
Doesn't the Image plugin support fetching url if it is not local ? So it is not \
needed for this function right ?
Also what about exposing the mode also - to be able to change between "SingleImage" \
and "Slideshow" mode ? Or should we make this just "SingleImage" ?
- Varun
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105319/#review15226
-----------------------------------------------------------
On June 24, 2012, 3:47 p.m., Varun Herale wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/105319/
> -----------------------------------------------------------
>
> (Updated June 24, 2012, 3:47 p.m.)
>
>
> Review request for Plasma.
>
>
> Description
> -------
>
> This patch is for hosting a dbus-interface that can be used to load any installed \
> wallpaper plugin onto current desktop containment. In case of default "image" \
> plugin, the path to the image can also be sent which will change the wallpaper.
>
> Diffs
> -----
>
> plasma/desktop/shell/dbus/org.kde.plasma.App.xml eefce32
> plasma/desktop/shell/plasmaapp.h 6ae0c89
> plasma/desktop/shell/plasmaapp.cpp 7abd8fc
>
> Diff: http://git.reviewboard.kde.org/r/105319/diff/
>
>
> Testing
> -------
>
> Tested on different activities and made sure it works for per-virtual desktop \
> containment.
> Haven't tested on a system with multiple screens though, as I don't have access to \
> one. Could someone please test for that ?
>
> Thanks,
>
> Varun Herale
>
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/105319/">http://git.reviewboard.kde.org/r/105319/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <p style="margin-top: 0;">On June 28th, 2012, 4:48 p.m., <b>Aaron J. \
Seigo</b> wrote:</p> <blockquote style="margin-left: 1em; border-left: 2px solid \
#d0d0d0; padding-left: 10px;">
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="http://git.reviewboard.kde.org/r/105319/diff/5/?file=70293#file70293line397" \
style="color: black; font-weight: bold; text-decoration: \
underline;">plasma/desktop/shell/plasmaapp.cpp</a> <span style="font-weight: \
normal;">
(Diff revision 5)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">void \
PlasmaApp::cleanup()</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th> <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">397</font></th> <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span \
class="kt">void</span> <span class="n">PlasmaApp</span><span class="o">::</span><span \
class="n">setWallpaper</span><span class="p">(</span><span class="k">const</span> \
<span class="n">QString</span> <span class="o">&</span><span \
class="n">name</span><span class="p">,</span> <span class="k">const</span> <span \
class="n">QString</span> <span class="o">&</span><span class="n">mode</span><span \
class="p">,</span> <span class="k">const</span> <span class="n">QString</span> <span \
class="o">&</span><span class="n">path</span><span class="p">)</span></pre></td> \
</tr>
</tbody>
</table>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">i would prefer it if the \
plugin name and mode were not exposed. the use case is "setting a wallpaper \
image" so let's implement that.
the main problem with being able to set the name and mode is that not only are most \
of the plugins optional (just asking for fun breakage) but also require \
configuration.
so i would recommend a rather simpler setWallpaperImage(const QString &url).
it should probably do similar to what the drag and drop support does and if the url \
is not local then try to fetch it using KIO.</pre> </blockquote>
</blockquote>
<pre style="margin-left: 1em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Doesn't \
the Image plugin support fetching url if it is not local ? So it is not needed for \
this function right ?
Also what about exposing the mode also - to be able to change between \
"SingleImage" and "Slideshow" mode ? Or should we make this just \
"SingleImage" ?</pre> <br />
<p>- Varun</p>
<br />
<p>On June 24th, 2012, 3:47 p.m., Varun Herale wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for Plasma.</div>
<div>By Varun Herale.</div>
<p style="color: grey;"><i>Updated June 24, 2012, 3:47 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">This patch is for hosting a dbus-interface that can be used to load any \
installed wallpaper plugin onto current desktop containment. In case of default \
"image" plugin, the path to the image can also be sent which will change \
the wallpaper. </pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Tested on different activities and made sure it works for per-virtual \
desktop containment.
Haven't tested on a system with multiple screens though, as I don't have \
access to one. Could someone please test for that ?</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>plasma/desktop/shell/dbus/org.kde.plasma.App.xml <span style="color: \
grey">(eefce32)</span></li>
<li>plasma/desktop/shell/plasmaapp.h <span style="color: grey">(6ae0c89)</span></li>
<li>plasma/desktop/shell/plasmaapp.cpp <span style="color: \
grey">(7abd8fc)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/105319/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic