'Re: Review Request: change default config of taskmanager'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    Re: Review Request: change default config of taskmanager
From:       "Greg T" <yellowcake- () gmx ! net>
Date:       2012-06-28 19:03:22
Message-ID: 20120628190322.5224.49559 () vidsolbach ! de
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105374/
-----------------------------------------------------------

(Updated June 28, 2012, 7:03 p.m.)

Review request for Plasma.

Changes
-------

Entirely new patch...that preferred application stuff feels like a hack.

Description
-------

libtaskmanager can't remove those ("browser", "preferred://browser, , , ") entrys, so \
I moved them to the Items list. I don't know why they were separated in the first \
place. That's why I'm opening this review request.

This addresses bug 278724.
    http://bugs.kde.org/show_bug.cgi?id=278724

Diffs (updated)
-----

  libs/taskmanager/groupmanager.cpp 5ca0159 

Diff: http://git.reviewboard.kde.org/r/105374/diff/

Testing
-------

no regressions noted.

Thanks,

Greg T

[Attachment #5 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="http://git.reviewboard.kde.org/r/105374/">http://git.reviewboard.kde.org/r/105374/</a>
  </td>
    </tr>
   </table>
   <br />

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;">  <tr>
  <td>

<div>Review request for Plasma.</div>
<div>By Greg T.</div>

<p style="color: grey;"><i>Updated June 28, 2012, 7:03 p.m.</i></p>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Changes</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Entirely new patch...that preferred application stuff feels like a \
hack.</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">libtaskmanager can&#39;t remove those (&quot;browser&quot;, \
&quot;preferred://browser, , , &quot;) entrys, so I moved them to the Items list. I \
don&#39;t know why they were separated in the first place. That&#39;s why I&#39;m \
opening this review request.</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">no regressions noted.</pre>  </td>
 </tr>
</table>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>

 <a href="http://bugs.kde.org/show_bug.cgi?id=278724">278724</a>

</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> \
(updated)</h1> <ul style="margin-left: 3em; padding-left: 0;">

 <li>libs/taskmanager/groupmanager.cpp <span style="color: \
grey">(5ca0159)</span></li>

</ul>

<p><a href="http://git.reviewboard.kde.org/r/105374/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[prev in list] [next in list] [prev in thread] [next in thread] 