--===============8678772043644282606== Content-Type: multipart/alternative; boundary="===============2127849396333009361==" --===============2127849396333009361== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable > On June 18, 2012, 3:37 p.m., Viranch Mehta wrote: > > The button size and the hover appearance is different from the original= one. The IconButton component was made to keep the look of the buttons con= sistent with the original version of the applet. Do we want to change this? > = > David Edmundson wrote: > Valid argument for now, won't be valid when everything moves to QML/P= lasma Components. > = > You're maintainer, you have final say. > If you want me to wait till 4.10 when more applets are QML based I wi= ll do. > = > Viranch Mehta wrote: > Well after a second thought, I think its a better idea to use plasma = components for consistency over plasma rather than maintaining consistency = with previous versions. but the original button for some reason looks *real= ly* better in visual terms to me (in fact, the button is also used in some = other plasmoids including the network manager). so... > = > to plasma components dev: can we have an option in the button of what= background svg is used? may be a switch between the current one and the on= e in this plasmoid (widgets/viewitem)? > = > if that may take time to come up, or is not desired, we can have this= patch shipped right in! > = > Viranch Mehta wrote: > david, please ship this patch for now. thanks! i don't think we want to allow defining which SVG is used, but it could mak= e sense to have a property that can be set to adjust the look based on wher= e/how the button is used. - Aaron J. ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105283/#review14839 ----------------------------------------------------------- On June 17, 2012, 7:52 p.m., David Edmundson wrote: > = > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/105283/ > ----------------------------------------------------------- > = > (Updated June 17, 2012, 7:52 p.m.) > = > = > Review request for Plasma. > = > = > Description > ------- > = > Current battery monitor implements it's own Button class, this previously= broke styles with theme text and overloads icon sizes and such. > = > It's bad for applets to implement their own version of common classes as = it prevents consistency. > = > (will fix the whitespace addition before commit) > = > = > Diffs > ----- > = > plasma/generic/applets/batterymonitor/contents/ui/IconButton.qml d4454c= 6 = > plasma/generic/applets/batterymonitor/contents/ui/PopupDialog.qml a2ab7= 2a = > = > Diff: http://git.reviewboard.kde.org/r/105283/diff/ > = > = > Testing > ------- > = > Checked applet looked ok. > = > = > Thanks, > = > David Edmundson > = > --===============2127849396333009361== Content-Type: text/html; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable
This is an automatically generated e-mail. To reply, visit: http://git.revie= wboard.kde.org/r/105283/

On June 18th, 2012, 3:37 p.m., Viranch Meht= a wrote:

The butto=
n size and the hover appearance is different from the original one. The Ico=
nButton component was made to keep the look of the buttons consistent with =
the original version of the applet. Do we want to change this?

On June 20th, 2012, 3:15 p.m., David Edmundson wrote:

Valid arg=
ument for now, won't be valid when everything moves to QML/Plasma Compo=
nents.

You're maintainer, you have final say.
If you want me to wait till 4.10 when more applets are QML based I will do.=

On June 20th, 2012, 6:30 p.m., Viranch Mehta wrote:

Well afte=
r a second thought, I think its a better idea to use plasma components for =
consistency over plasma rather than maintaining consistency with previous v=
ersions. but the original button for some reason looks *really* better in v=
isual terms to me (in fact, the button is also used in some other plasmoids=
 including the network manager). so...

to plasma components dev: can we have an option in the button of what backg=
round svg is used? may be a switch between the current one and the one in t=
his plasmoid (widgets/viewitem)?

if that may take time to come up, or is not desired, we can have this patch=
 shipped right in!

On June 21st, 2012, 12:49 p.m., Viranch Mehta wrote:

david, pl=
ease ship this patch for now. thanks!
i don't=
 think we want to allow defining which SVG is used, but it could make sense=
 to have a property that can be set to adjust the look based on where/how t=
he button is used.

- Aaron J.


On June 17th, 2012, 7:52 p.m., David Edmundson wrote:

Review request for Plasma.
By David Edmundson.

Updated June 17, 2012, 7:52 p.m.

Descripti= on 

Current battery monitor implements it's own Button class=
, this previously broke styles with theme text and overloads icon sizes and=
 such.

It's bad for applets to implement their own version of common classes a=
s it prevents consistency.

(will fix the whitespace addition before commit)

Testing <= /h1> 
Checked applet looked ok.

Diffs=

  • plasma/generic/applets/batterymonitor/contents/ui/IconButton.qml (d4454c6)
  • plasma/generic/applets/batterymonitor/contents/ui/PopupDialog.qml (a2ab72a)

View Diff
--===============2127849396333009361==-- --===============8678772043644282606== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel --===============8678772043644282606==--