[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-panel-devel
Subject: Review Request: Plasma qml-Components ToolButton: change text-color on hover more fluently
From: Johannes_Tröscher <fritz_van_tom () hotmail ! com>
Date: 2012-06-28 15:40:59
Message-ID: 20120628154059.20133.84646 () vidsolbach ! de
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105375/
-----------------------------------------------------------
Review request for Plasma and Aaron J. Seigo.
Description
-------
this is mostly visible with dark-themes only.
as of now the text color got only changed when the "hover-element" was full=
y visible. this looked a bit weird.
this patch adds a ColorAnimation with the same duration as the opacity-anim=
ation on the "hover-element" as Behavior for the Label.
now the color changes fluently on hovering the ToolButton
Diffs
-----
plasma/declarativeimports/plasmacomponents/qml/ToolButton.qml 1655821 =
Diff: http://git.reviewboard.kde.org/r/105375/diff/
Testing
-------
tested, works
Thanks,
Johannes Tr=C3=B6scher
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/105375/">http://git.reviewboard.kde.org/r/105375/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for Plasma and Aaron J. Seigo.</div>
<div>By Johannes Tröscher.</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">this is mostly visible with dark-themes only. as of now the text color \
got only changed when the "hover-element" was fully visible. this looked a \
bit weird. this patch adds a ColorAnimation with the same duration as the \
opacity-animation on the "hover-element" as Behavior for the Label. now the \
color changes fluently on hovering the ToolButton</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">tested, works</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>plasma/declarativeimports/plasmacomponents/qml/ToolButton.qml <span \
style="color: grey">(1655821)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/105375/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic