[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-panel-devel
Subject: Re: Review Request: Rework layout of widget explorer and activity manager in vertical mode
From: Aurélien Gâteau <agateau () kde ! org>
Date: 2012-06-25 12:09:58
Message-ID: 20120625120958.6630.32456 () vidsolbach ! de
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105329/
-----------------------------------------------------------
(Updated June 25, 2012, 12:09 p.m.)
Review request for Plasma, KDE Usability and Marco Martin.
Changes
-------
- Expand items to use full width when scrollbar is not visible.
- Use bold text for label title, and word wrap label body, limiting it to 3=
lines.
Description
-------
I made a few changes to make widget explorer nicer in vertical mode
- Fix cropped list items.
- Make buttons use full width.
- Move "Get new widgets" and action buttons to the bottom so that:
- different label alignments do not look odd (category button vs others)
- category button is closer to the list it controls
Additionally it would be much better if tooltips could appear on the right =
(or left) of the current list item instead of on top of it because it easil=
y gets in the way, but I don't know how to do this. Any idea? An alternativ=
e would be to just drop the tooltip, it currently does more harm than good =
imo.
There is also something weird going on with the backgrounds: the "after" sc=
reenshots use a opaque background, but that is not part of the patch and I =
don't understand what makes the code pick the opaque or transparent backgro=
und. It should be fixed to use the opaque background, again, any idea where=
that bug could be?
Diffs (updated)
-----
libs/plasmagenericshell/widgetsexplorer/package/contents/ui/AppletDelegat=
e.qml 68fad80 =
libs/plasmagenericshell/widgetsexplorer/package/contents/ui/main.qml 4bee=
cec =
plasma/desktop/shell/activitymanager/package/contents/ui/main.qml 1886529 =
Diff: http://git.reviewboard.kde.org/r/105329/diff/
Testing
-------
- Looks better in vertical mode.
- No regression in horizontal mode.
Screenshots
-----------
before-after
http://git.reviewboard.kde.org/r/105329/s/610/
Thanks,
Aur=C3=A9lien G=C3=A2teau
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/105329/">http://git.reviewboard.kde.org/r/105329/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for Plasma, KDE Usability and Marco Martin.</div>
<div>By Aurélien Gâteau.</div>
<p style="color: grey;"><i>Updated June 25, 2012, 12:09 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Changes</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">- Expand items to use full width when scrollbar is not \
visible.
- Use bold text for label title, and word wrap label body, limiting it to 3 \
lines.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">I made a few changes to make widget explorer nicer in vertical mode
- Fix cropped list items.
- Make buttons use full width.
- Move "Get new widgets" and action buttons to the bottom so that:
- different label alignments do not look odd (category button vs others)
- category button is closer to the list it controls
Additionally it would be much better if tooltips could appear on the right (or left) \
of the current list item instead of on top of it because it easily gets in the way, \
but I don't know how to do this. Any idea? An alternative would be to just drop \
the tooltip, it currently does more harm than good imo.
There is also something weird going on with the backgrounds: the "after" \
screenshots use a opaque background, but that is not part of the patch and I \
don't understand what makes the code pick the opaque or transparent background. \
It should be fixed to use the opaque background, again, any idea where that bug could \
be?</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">- Looks better in vertical mode.
- No regression in horizontal mode.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> \
(updated)</h1> <ul style="margin-left: 3em; padding-left: 0;">
<li>libs/plasmagenericshell/widgetsexplorer/package/contents/ui/AppletDelegate.qml \
<span style="color: grey">(68fad80)</span></li>
<li>libs/plasmagenericshell/widgetsexplorer/package/contents/ui/main.qml <span \
style="color: grey">(4beecec)</span></li>
<li>plasma/desktop/shell/activitymanager/package/contents/ui/main.qml <span \
style="color: grey">(1886529)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/105329/diff/" style="margin-left: \
3em;">View Diff</a></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Screenshots </h1>
<div>
<a href="http://git.reviewboard.kde.org/r/105329/s/610/"><img \
src="http://git.reviewboard.kde.org/media/uploaded/images/2012/06/25/out_400x100.png" \
style="border: 1px black solid;" alt="before-after" /></a>
</div>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic