[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-panel-devel
Subject: Re: Review Request: DBus-interface for changing wallpapers
From: "David Edmundson" <kde () davidedmundson ! co ! uk>
Date: 2012-06-24 15:51:55
Message-ID: 20120624155155.20837.26536 () vidsolbach ! de
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105319/#review15062
-----------------------------------------------------------
Ship it!
Looks great.
It's a new feature though so don't ship it till after the feature freeze en=
ds for 4.9. (unless someone else gives you permission)
=
- David Edmundson
On June 24, 2012, 3:47 p.m., Varun Herale wrote:
> =
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/105319/
> -----------------------------------------------------------
> =
> (Updated June 24, 2012, 3:47 p.m.)
> =
> =
> Review request for Plasma.
> =
> =
> Description
> -------
> =
> This patch is for hosting a dbus-interface that can be used to load any i=
nstalled wallpaper plugin onto current desktop containment. In case of defa=
ult "image" plugin, the path to the image can also be sent which will chang=
e the wallpaper. =
> =
> =
> Diffs
> -----
> =
> plasma/desktop/shell/dbus/org.kde.plasma.App.xml eefce32 =
> plasma/desktop/shell/plasmaapp.h 6ae0c89 =
> plasma/desktop/shell/plasmaapp.cpp 7abd8fc =
> =
> Diff: http://git.reviewboard.kde.org/r/105319/diff/
> =
> =
> Testing
> -------
> =
> Tested on different activities and made sure it works for per-virtual des=
ktop containment.
> =
> Haven't tested on a system with multiple screens though, as I don't have =
access to one. Could someone please test for that ?
> =
> =
> Thanks,
> =
> Varun Herale
> =
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/105319/">http://git.reviewboard.kde.org/r/105319/</a>
</td>
</tr>
</table>
<br />
<p>Ship it!</p>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Looks great.
It's a new feature though so don't ship it till after the feature freeze ends \
for 4.9. (unless someone else gives you permission)
</pre>
<br />
<p>- David</p>
<br />
<p>On June 24th, 2012, 3:47 p.m., Varun Herale wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for Plasma.</div>
<div>By Varun Herale.</div>
<p style="color: grey;"><i>Updated June 24, 2012, 3:47 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">This patch is for hosting a dbus-interface that can be used to load any \
installed wallpaper plugin onto current desktop containment. In case of default \
"image" plugin, the path to the image can also be sent which will change \
the wallpaper. </pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Tested on different activities and made sure it works for per-virtual \
desktop containment.
Haven't tested on a system with multiple screens though, as I don't have \
access to one. Could someone please test for that ?</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>plasma/desktop/shell/dbus/org.kde.plasma.App.xml <span style="color: \
grey">(eefce32)</span></li>
<li>plasma/desktop/shell/plasmaapp.h <span style="color: grey">(6ae0c89)</span></li>
<li>plasma/desktop/shell/plasmaapp.cpp <span style="color: \
grey">(7abd8fc)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/105319/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic