[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-panel-devel
Subject: Re: Review Request: Add missing email addresses back into add widget tooltip.
From: "David Edmundson" <kde () davidedmundson ! co ! uk>
Date: 2012-06-24 0:39:58
Message-ID: 20120624003958.21119.52483 () vidsolbach ! de
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105312/#review15051
-----------------------------------------------------------
The reason the link doesn't work is that by default QML label links do noth=
ing but emit a signal when clicked
in the label add:
onLinkActivated: {
plasmoid.openUrl(link);
}
libs/plasmagenericshell/widgetsexplorer/plasmaappletitemmodel_p.h
<http://git.reviewboard.kde.org/r/105312/#comment11836>
Good spot!
- David Edmundson
On June 21, 2012, 4:39 a.m., Matthew John Dawson wrote:
> =
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/105312/
> -----------------------------------------------------------
> =
> (Updated June 21, 2012, 4:39 a.m.)
> =
> =
> Review request for Plasma, Ivan =C4=8Cuki=C4=87 and Marco Martin.
> =
> =
> Description
> -------
> =
> When the QML port of the add widget dialog occured, the creator's email a=
ddress got chopped off. This commit fixes a bug hidding the email address,=
and also starts displaying it again in the tooltip.
> =
> There are a couple of issue left with this patch:
> 1) I have to disable wrapping, otherwise the text wraps at odd points for=
no reason (it fits fine otherwise).
> 2) The link currently doesn't work as I'm not sure how to hook it up to s=
end mail. Should it be left as is, or just remove the link for 4.9 and upd=
ate with a link for 4.10?
> =
> =
> Diffs
> -----
> =
> libs/plasmagenericshell/widgetsexplorer/package/contents/ui/Tooltip.qml=
ba804fd006496ee4a7118e97fe44038f0617eec7 =
> libs/plasmagenericshell/widgetsexplorer/plasmaappletitemmodel_p.h e745e=
f58533ab0e22d2109d5beeff6c29c4d18b4 =
> =
> Diff: http://git.reviewboard.kde.org/r/105312/diff/
> =
> =
> Testing
> -------
> =
> Tested locally in Xephyr. The tooltip now contains the email address.
> =
> =
> Thanks,
> =
> Matthew John Dawson
> =
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/105312/">http://git.reviewboard.kde.org/r/105312/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">The reason the link \
doesn't work is that by default QML label links do nothing but emit a signal when \
clicked
in the label add:
onLinkActivated: {
plasmoid.openUrl(link);
}
</pre>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="http://git.reviewboard.kde.org/r/105312/diff/1/?file=69993#file69993line92" \
style="color: black; font-weight: bold; text-decoration: \
underline;">libs/plasmagenericshell/widgetsexplorer/plasmaappletitemmodel_p.h</a> \
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; \
">public:</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2">92</font></th> <td bgcolor="#fdfebc" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "> <span \
class="n">RunningRole</span> <span class="o">=</span> <span class="n">Qt</span><span \
class="o">::</span><span class="n">UserRole</span><span class="o">+</span><span \
class="mi"><span class="hl">9</span></span><span class="p">,</span></pre></td> <th \
bgcolor="#e9eaa8" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">92</font></th> <td bgcolor="#fdfebc" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span \
class="n">RunningRole</span> <span class="o">=</span> <span class="n">Qt</span><span \
class="o">::</span><span class="n">UserRole</span><span class="o">+</span><span \
class="mi"><span class="hl">10</span></span><span class="p">,</span></pre></td> \
</tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Good \
spot!</pre> </div>
<br />
<p>- David</p>
<br />
<p>On June 21st, 2012, 4:39 a.m., Matthew John Dawson wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for Plasma, Ivan Čukić and Marco Martin.</div>
<div>By Matthew John Dawson.</div>
<p style="color: grey;"><i>Updated June 21, 2012, 4:39 a.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">When the QML port of the add widget dialog occured, the creator's \
email address got chopped off. This commit fixes a bug hidding the email address, \
and also starts displaying it again in the tooltip.
There are a couple of issue left with this patch:
1) I have to disable wrapping, otherwise the text wraps at odd points for no reason \
(it fits fine otherwise). 2) The link currently doesn't work as I'm not sure \
how to hook it up to send mail. Should it be left as is, or just remove the link for \
4.9 and update with a link for 4.10?</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Tested locally in Xephyr. The tooltip now contains the email \
address.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>libs/plasmagenericshell/widgetsexplorer/package/contents/ui/Tooltip.qml <span \
style="color: grey">(ba804fd006496ee4a7118e97fe44038f0617eec7)</span></li>
<li>libs/plasmagenericshell/widgetsexplorer/plasmaappletitemmodel_p.h <span \
style="color: grey">(e745ef58533ab0e22d2109d5beeff6c29c4d18b4)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/105312/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic