[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-panel-devel
Subject: Re: Review Request: DBus-interface for changing wallpapers
From: "David Edmundson" <kde () davidedmundson ! co ! uk>
Date: 2012-06-22 12:46:40
Message-ID: 20120622124640.6309.52754 () vidsolbach ! de
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105319/#review14996
-----------------------------------------------------------
plasma/desktop/shell/plasmaapp.cpp
<http://git.reviewboard.kde.org/r/105319/#comment11790>
I think this leaks :-S
lib kactivities has a method for this, you may as well just use that.
KActivities::Controller activityController;
QString currentActivity = activityController.currentActivity();
then add ${KACTIVITIES_LIBRARY} to your target_link_libraries in CMakeLists.txt
- David Edmundson
On June 22, 2012, 2:07 a.m., Varun Herale wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/105319/
> -----------------------------------------------------------
>
> (Updated June 22, 2012, 2:07 a.m.)
>
>
> Review request for Plasma.
>
>
> Description
> -------
>
> This patch is for hosting a dbus-interface that can be used to load any installed \
> wallpaper plugin onto current desktop containment. In case of default "image" \
> plugin, the path to the image can also be sent which will change the wallpaper.
>
> Diffs
> -----
>
> plasma/desktop/shell/dbus/org.kde.plasma.App.xml eefce32
> plasma/desktop/shell/plasmaapp.h 6ae0c89
> plasma/desktop/shell/plasmaapp.cpp 7abd8fc
>
> Diff: http://git.reviewboard.kde.org/r/105319/diff/
>
>
> Testing
> -------
>
> Tested on different activities and made sure it works for per-virtual desktop \
> containment.
> Haven't tested on a system with multiple screens though, as I don't have access to \
> one. Could someone please test for that ?
>
> Thanks,
>
> Varun Herale
>
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/105319/">http://git.reviewboard.kde.org/r/105319/</a>
</td>
</tr>
</table>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="http://git.reviewboard.kde.org/r/105319/diff/3/?file=70115#file70115line411" \
style="color: black; font-weight: bold; text-decoration: \
underline;">plasma/desktop/shell/plasmaapp.cpp</a> <span style="font-weight: \
normal;">
(Diff revision 3)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="2"><pre style="font-size: 8pt; line-height: 140%; margin: 0; \
"></pre></td> <td colspan="2"><pre style="font-size: 8pt; line-height: 140%; margin: \
0; ">void PlasmaApp::setWallpaper(const QString &name, const QString &mode, \
const QString &path)</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th> <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">411</font></th> <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span \
class="n">QDBusInterface</span> <span class="o">*</span><span \
class="n">actInterface</span> <span class="o">=</span> <span class="k">new</span> \
<span class="n">QDBusInterface</span><span class="p">(</span><span \
class="s">"org.kde.kactivitymanagerd"</span><span \
class="p">,</span></pre></td> </tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I think \
this leaks :-S
lib kactivities has a method for this, you may as well just use that.
KActivities::Controller activityController;
QString currentActivity = activityController.currentActivity();
then add ${KACTIVITIES_LIBRARY} to your target_link_libraries in CMakeLists.txt
</pre>
</div>
<br />
<p>- David</p>
<br />
<p>On June 22nd, 2012, 2:07 a.m., Varun Herale wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for Plasma.</div>
<div>By Varun Herale.</div>
<p style="color: grey;"><i>Updated June 22, 2012, 2:07 a.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">This patch is for hosting a dbus-interface that can be used to load any \
installed wallpaper plugin onto current desktop containment. In case of default \
"image" plugin, the path to the image can also be sent which will change \
the wallpaper. </pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Tested on different activities and made sure it works for per-virtual \
desktop containment.
Haven't tested on a system with multiple screens though, as I don't have \
access to one. Could someone please test for that ?</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>plasma/desktop/shell/dbus/org.kde.plasma.App.xml <span style="color: \
grey">(eefce32)</span></li>
<li>plasma/desktop/shell/plasmaapp.h <span style="color: grey">(6ae0c89)</span></li>
<li>plasma/desktop/shell/plasmaapp.cpp <span style="color: \
grey">(7abd8fc)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/105319/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic