[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-panel-devel
Subject: Re: Review Request: improve/add keyboard navigation in kickoff-qml (mystery included)
From: "Greg T" <yellowcake- () gmx ! net>
Date: 2012-06-18 18:39:44
Message-ID: 20120618183944.4135.4408 () vidsolbach ! de
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
> On June 10, 2012, 7:56 a.m., Martin Gr=C3=A4=C3=9Flin wrote:
> > cool, thanks for taking up where I left the work. I appreciate that ver=
y much.
> > =
> > I have no idea about the key handling issue. I will try to test out the=
branch next week and play with it.
> > =
> > As everything is in a branch, I'm fine if you develop in it without rev=
iew requests, though if you want to get the feedback you are of course welc=
ome to open a request.
Alright, I have figured it out for myself. :) With my latest commit keyboar=
d navigation should be fine. You are welcome to test and review it.
- Greg
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105196/#review14571
-----------------------------------------------------------
On June 9, 2012, 12:32 p.m., Greg T wrote:
> =
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/105196/
> -----------------------------------------------------------
> =
> (Updated June 9, 2012, 12:32 p.m.)
> =
> =
> Review request for Plasma and Martin Gr=C3=A4=C3=9Flin.
> =
> =
> Description
> -------
> =
> since qml is my new hobby I'm trying to work on some little projects ;). =
Well, this is a first step towards adding usable keyboard navigation to kic=
koff. Big problem: Somehow the Key_Left keypress event gets swallowed. You =
are supposed to control the tabbar by hitting left and right arrow key, jus=
t as with c++ kickoff. atm you can just go to the right. any help on debugg=
ing this issue is really appreciated.
> =
> =
> Diffs
> -----
> =
> plasma/desktop/applets/kickoff/package/contents/ui/KickoffItem.qml 919e=
6f7 =
> plasma/desktop/applets/kickoff/package/contents/ui/MainView.qml 7fc9d2b =
> plasma/desktop/applets/kickoff/package/contents/ui/kickoff.qml 4a9a5e6 =
> =
> Diff: http://git.reviewboard.kde.org/r/105196/diff/
> =
> =
> Testing
> -------
> =
> kinda works
> =
> =
> Thanks,
> =
> Greg T
> =
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/105196/">http://git.reviewboard.kde.org/r/105196/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <p style="margin-top: 0;">On June 10th, 2012, 7:56 a.m., <b>Martin \
Gräßlin</b> wrote:</p> <blockquote style="margin-left: 1em; border-left: 2px solid \
#d0d0d0; padding-left: 10px;"> <pre style="white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">cool, thanks for taking up where I left the work. I appreciate that very \
much.
I have no idea about the key handling issue. I will try to test out the branch next \
week and play with it.
As everything is in a branch, I'm fine if you develop in it without review \
requests, though if you want to get the feedback you are of course welcome to open a \
request.</pre> </blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Alright, I have figured \
it out for myself. :) With my latest commit keyboard navigation should be fine. You \
are welcome to test and review it.</pre> <br />
<p>- Greg</p>
<br />
<p>On June 9th, 2012, 12:32 p.m., Greg T wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for Plasma and Martin Gräßlin.</div>
<div>By Greg T.</div>
<p style="color: grey;"><i>Updated June 9, 2012, 12:32 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">since qml is my new hobby I'm trying to work on some little projects \
;). Well, this is a first step towards adding usable keyboard navigation to kickoff. \
Big problem: Somehow the Key_Left keypress event gets swallowed. You are supposed to \
control the tabbar by hitting left and right arrow key, just as with c++ kickoff. atm \
you can just go to the right. any help on debugging this issue is really \
appreciated.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">kinda works</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>plasma/desktop/applets/kickoff/package/contents/ui/KickoffItem.qml <span \
style="color: grey">(919e6f7)</span></li>
<li>plasma/desktop/applets/kickoff/package/contents/ui/MainView.qml <span \
style="color: grey">(7fc9d2b)</span></li>
<li>plasma/desktop/applets/kickoff/package/contents/ui/kickoff.qml <span \
style="color: grey">(4a9a5e6)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/105196/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic