[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-panel-devel
Subject: Re: Review Request: Use common plasma components Tooltip in battery monitor
From: "Viranch Mehta" <viranch.mehta () gmail ! com>
Date: 2012-06-18 15:37:30
Message-ID: 20120618153730.8771.83470 () vidsolbach ! de
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105283/#review14839
-----------------------------------------------------------
The button size and the hover appearance is different from the original one=
. The IconButton component was made to keep the look of the buttons consist=
ent with the original version of the applet. Do we want to change this?
- Viranch Mehta
On June 17, 2012, 7:52 p.m., David Edmundson wrote:
> =
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/105283/
> -----------------------------------------------------------
> =
> (Updated June 17, 2012, 7:52 p.m.)
> =
> =
> Review request for Plasma.
> =
> =
> Description
> -------
> =
> Current battery monitor implements it's own Button class, this previously=
broke styles with theme text and overloads icon sizes and such.
> =
> It's bad for applets to implement their own version of common classes as =
it prevents consistency.
> =
> (will fix the whitespace addition before commit)
> =
> =
> Diffs
> -----
> =
> plasma/generic/applets/batterymonitor/contents/ui/IconButton.qml d4454c=
6 =
> plasma/generic/applets/batterymonitor/contents/ui/PopupDialog.qml a2ab7=
2a =
> =
> Diff: http://git.reviewboard.kde.org/r/105283/diff/
> =
> =
> Testing
> -------
> =
> Checked applet looked ok.
> =
> =
> Thanks,
> =
> David Edmundson
> =
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/105283/">http://git.reviewboard.kde.org/r/105283/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">The button size and the \
hover appearance is different from the original one. The IconButton component was \
made to keep the look of the buttons consistent with the original version of the \
applet. Do we want to change this?</pre> <br />
<p>- Viranch</p>
<br />
<p>On June 17th, 2012, 7:52 p.m., David Edmundson wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for Plasma.</div>
<div>By David Edmundson.</div>
<p style="color: grey;"><i>Updated June 17, 2012, 7:52 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Current battery monitor implements it's own Button class, this \
previously broke styles with theme text and overloads icon sizes and such.
It's bad for applets to implement their own version of common classes as it \
prevents consistency.
(will fix the whitespace addition before commit)</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Checked applet looked ok.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>plasma/generic/applets/batterymonitor/contents/ui/IconButton.qml <span \
style="color: grey">(d4454c6)</span></li>
<li>plasma/generic/applets/batterymonitor/contents/ui/PopupDialog.qml <span \
style="color: grey">(a2ab72a)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/105283/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic