'Re: Review Request: Add a keyboard shortcut to stop the current activity'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    Re: Review Request: Add a keyboard shortcut to stop the current activity
From:       "Kai Uwe Broulik" <kde () privat ! broulik ! de>
Date:       2012-06-18 1:38:51
Message-ID: 20120618013851.5984.13252 () vidsolbach ! de
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105279/#review14818
-----------------------------------------------------------

I'd argue not few people use Meta+S for Stop Playback, Meta+P for Pause, etc.

- Kai Uwe Broulik

On June 16, 2012, 11:39 p.m., David Edmundson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/105279/
> -----------------------------------------------------------
> 
> (Updated June 16, 2012, 11:39 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Description
> -------
> 
> Add a keyboard shortcut to stop the current activity. This was suggested at the KDE \
> Workspace sprint in order to improve workflow. 
> Intend to merge into 4.10 after freeze not 4.9. Also happy to discuss alternate \
> default key shortcuts.  
> 
> This addresses bug 302003.
> http://bugs.kde.org/show_bug.cgi?id=302003
> 
> 
> Diffs
> -----
> 
> plasma/desktop/shell/desktopcorona.h df111b2 
> plasma/desktop/shell/desktopcorona.cpp c7f3eec 
> 
> Diff: http://git.reviewboard.kde.org/r/105279/diff/
> 
> 
> Testing
> -------
> 
> Pressed shortcut, tested current activity closed, and that I could not close the \
> last activity. 
> 
> Thanks,
> 
> David Edmundson
> 
> 

[Attachment #5 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="http://git.reviewboard.kde.org/r/105279/">http://git.reviewboard.kde.org/r/105279/</a>
  </td>
    </tr>
   </table>
   <br />

 <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I'd argue not few people \
use Meta+S for Stop Playback, Meta+P for Pause, etc.</pre>  <br />

<p>- Kai Uwe</p>

<br />
<p>On June 16th, 2012, 11:39 p.m., David Edmundson wrote:</p>

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;">  <tr>
  <td>

<div>Review request for Plasma.</div>
<div>By David Edmundson.</div>

<p style="color: grey;"><i>Updated June 16, 2012, 11:39 p.m.</i></p>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Add a keyboard shortcut to stop the current activity. This was suggested \
at the KDE Workspace sprint in order to improve workflow.

Intend to merge into 4.10 after freeze not 4.9. Also happy to discuss alternate \
default key shortcuts.  </pre>
  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Pressed shortcut, tested current activity closed, and that I could not \
close the last activity.</pre>  </td>
 </tr>
</table>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>

 <a href="http://bugs.kde.org/show_bug.cgi?id=302003">302003</a>

</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>plasma/desktop/shell/desktopcorona.h <span style="color: \
grey">(df111b2)</span></li>

 <li>plasma/desktop/shell/desktopcorona.cpp <span style="color: \
grey">(c7f3eec)</span></li>

</ul>

<p><a href="http://git.reviewboard.kde.org/r/105279/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[prev in list] [next in list] [prev in thread] [next in thread] 