'Re: Review Request: Fix sourceFilter to actually filter the sources in QML DataModel'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    Re: Review Request: Fix sourceFilter to actually filter the sources in QML DataModel
From:       "Commit Hook" <null () kde ! org>
Date:       2012-06-16 14:42:21
Message-ID: 20120616144221.26615.44842 () vidsolbach ! de
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105267/#review14798
-----------------------------------------------------------

This review has been submitted with commit 4542bfbc22e9b20c13d7687239c4392b=
a16e7d07 by Viranch Mehta to branch master.

- Commit Hook

On June 15, 2012, 10:20 p.m., Viranch Mehta wrote:
> =

> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/105267/
> -----------------------------------------------------------
> =

> (Updated June 15, 2012, 10:20 p.m.)
> =

> =

> Review request for Plasma and Marco Martin.
> =

> =

> Description
> -------
> =

> This fixes a bug in PlasmaCore.DataModel. The DataModel does not correctl=
y filter the sources when sourceFilter is provided.
> =

> The dataUpdated function does terminate when sourceName does not match th=
e sourceFilter, but when it does match, all sources from the data engine ar=
e added to the said DataModel instead of checking for the sourceFilter agai=
n. This patch introduces that check.
> =

> (the patch is clearer than the description)
> =

> =

> Diffs
> -----
> =

>   plasma/declarativeimports/core/datamodel.cpp 9400dbe =

> =

> Diff: http://git.reviewboard.kde.org/r/105267/diff/
> =

> =

> Testing
> -------
> =

> Tested with Battery Monitor applet when there are multiple batteries and =
a model is required consisting of only the battery sources from powermanage=
ment engine.
> =

> Works as expected with the patch.
> =

> =

> Thanks,
> =

> Viranch Mehta
> =

>

[Attachment #5 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="http://git.reviewboard.kde.org/r/105267/">http://git.reviewboard.kde.org/r/105267/</a>
  </td>
    </tr>
   </table>
   <br />

 <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This review has been \
submitted with commit 4542bfbc22e9b20c13d7687239c4392ba16e7d07 by Viranch Mehta to \
branch master.</pre>  <br />

<p>- Commit</p>

<br />
<p>On June 15th, 2012, 10:20 p.m., Viranch Mehta wrote:</p>

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;">  <tr>
  <td>

<div>Review request for Plasma and Marco Martin.</div>
<div>By Viranch Mehta.</div>

<p style="color: grey;"><i>Updated June 15, 2012, 10:20 p.m.</i></p>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">This fixes a bug in PlasmaCore.DataModel. The DataModel does not \
correctly filter the sources when sourceFilter is provided.

The dataUpdated function does terminate when sourceName does not match the \
sourceFilter, but when it does match, all sources from the data engine are added to \
the said DataModel instead of checking for the sourceFilter again. This patch \
introduces that check.

(the patch is clearer than the description)</pre>
  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Tested with Battery Monitor applet when there are multiple batteries and \
a model is required consisting of only the battery sources from powermanagement \
engine.

Works as expected with the patch.</pre>
  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>plasma/declarativeimports/core/datamodel.cpp <span style="color: \
grey">(9400dbe)</span></li>

</ul>

<p><a href="http://git.reviewboard.kde.org/r/105267/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[prev in list] [next in list] [prev in thread] [next in thread] 