[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-panel-devel
Subject: Re: Review Request: Plasmate: request to merge terietor/remoteinstaller to master
From: "Aaron J. Seigo" <aseigo () kde ! org>
Date: 2012-06-09 10:32:47
Message-ID: 20120609103247.14221.64582 () vidsolbach ! de
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105032/#review14536
-----------------------------------------------------------
publisher/remoteinstaller/remoteinstaller.cpp
<http://git.reviewboard.kde.org/r/105032/#comment11493>
this should be a call to create the directory, no?
publisher/remoteinstaller/remoteinstaller.cpp
<http://git.reviewboard.kde.org/r/105032/#comment11494>
if you move this line up a few then you can replace the "/var/tmp/plasm=
aremoteinstaller/" literals in the NetAccess calls above.
=
(also -> make it a const QString for correctness :)
- Aaron J. Seigo
On June 4, 2012, 4:54 p.m., Giorgos Tsiapaliwkas wrote:
> =
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/105032/
> -----------------------------------------------------------
> =
> (Updated June 4, 2012, 4:54 p.m.)
> =
> =
> Review request for Plasma.
> =
> =
> Description
> -------
> =
> Hello,
> =
> in terietor/remoteinstaller I have create a remote installer.
> The goal is to install the projects remotely to another computer.
> =
> You access the remote install either inside plasmate or using the plasmar=
emoteinstaller binary.
> =
> =
> Diffs
> -----
> =
> CMakeLists.txt 12f8a3a =
> publisher/publisher.h 5f40ae0 =
> publisher/publisher.cpp fd87364 =
> publisher/remoteinstaller/remoteinstaller.h PRE-CREATION =
> publisher/remoteinstaller/remoteinstaller.cpp PRE-CREATION =
> publisher/remoteinstaller/remoteinstaller.ui PRE-CREATION =
> publisher/remoteinstaller/remoteinstallerdialog.h PRE-CREATION =
> publisher/remoteinstaller/remoteinstallerdialog.cpp PRE-CREATION =
> publisher/remoteinstaller/standalone/main.cpp PRE-CREATION =
> publisher/remoteinstaller/standalone/plasmaremoteinstaller.h PRE-CREATI=
ON =
> publisher/remoteinstaller/standalone/plasmaremoteinstaller.cpp PRE-CREA=
TION =
> =
> Diff: http://git.reviewboard.kde.org/r/105032/diff/
> =
> =
> Testing
> -------
> =
> I couldn't find any bugs in the remote installer, but the proccess fails =
during KIO::copy.
> Apparently I am not writing correct something in the fish protocol.
> Right now the remote installer tries to do the above
> =
> KIO::copy("/home/terietor/.kde4/share/apps/plasmate/project, "fish://user=
@ip/home/user")
> =
> but it fails
> =
> =
> Thanks,
> =
> Giorgos Tsiapaliwkas
> =
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/105032/">http://git.reviewboard.kde.org/r/105032/</a>
</td>
</tr>
</table>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="http://git.reviewboard.kde.org/r/105032/diff/5/?file=66289#file66289line33" \
style="color: black; font-weight: bold; text-decoration: \
underline;">publisher/remoteinstaller/remoteinstaller.cpp</a> <span \
style="font-weight: normal;">
(Diff revision 5)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="2"><pre style="font-size: 8pt; line-height: 140%; margin: 0; \
"></pre></td> <td colspan="2"><pre style="font-size: 8pt; line-height: 140%; margin: \
0; ">RemoteInstaller::RemoteInstaller(const QString& username, const QString& \
hostname,</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th> <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">33</font></th> <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span \
class="n">KIO</span><span class="o">::</span><span class="n">NetAccess</span><span \
class="o">::</span><span class="n">exists</span><span class="p">(</span><span \
class="n">m_execUrl</span><span class="p">,</span> <span \
class="s">"/var/tmp/plasmaremoteinstaller/"</span><span class="p">,</span> \
<span class="n">m_widget</span><span class="p">);</span></pre></td> </tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">this should \
be a call to create the directory, no?</pre> </div>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="http://git.reviewboard.kde.org/r/105032/diff/5/?file=66289#file66289line36" \
style="color: black; font-weight: bold; text-decoration: \
underline;">publisher/remoteinstaller/remoteinstaller.cpp</a> <span \
style="font-weight: normal;">
(Diff revision 5)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="2"><pre style="font-size: 8pt; line-height: 140%; margin: 0; \
"></pre></td> <td colspan="2"><pre style="font-size: 8pt; line-height: 140%; margin: \
0; ">RemoteInstaller::RemoteInstaller(const QString& username, const QString& \
hostname,</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th> <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">36</font></th> <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span \
class="n">QString</span> <span class="n">temporaryDirectory</span><span \
class="p">(</span><span \
class="s">"/var/tmp/plasmaremoteinstaller/"</span><span \
class="p">);</span></pre></td> </tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">if you move \
this line up a few then you can replace the \
"/var/tmp/plasmaremoteinstaller/" literals in the NetAccess calls above.
(also -> make it a const QString for correctness :)</pre>
</div>
<br />
<p>- Aaron J.</p>
<br />
<p>On June 4th, 2012, 4:54 p.m., Giorgos Tsiapaliwkas wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for Plasma.</div>
<div>By Giorgos Tsiapaliwkas.</div>
<p style="color: grey;"><i>Updated June 4, 2012, 4:54 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Hello,
in terietor/remoteinstaller I have create a remote installer.
The goal is to install the projects remotely to another computer.
You access the remote install either inside plasmate or using the \
plasmaremoteinstaller binary.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">I couldn't find any bugs in the remote installer, but the proccess \
fails during KIO::copy. Apparently I am not writing correct something in the fish \
protocol. Right now the remote installer tries to do the above
KIO::copy("/home/terietor/.kde4/share/apps/plasmate/project, \
"fish://user@ip/home/user")
but it fails
</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>CMakeLists.txt <span style="color: grey">(12f8a3a)</span></li>
<li>publisher/publisher.h <span style="color: grey">(5f40ae0)</span></li>
<li>publisher/publisher.cpp <span style="color: grey">(fd87364)</span></li>
<li>publisher/remoteinstaller/remoteinstaller.h <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>publisher/remoteinstaller/remoteinstaller.cpp <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>publisher/remoteinstaller/remoteinstaller.ui <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>publisher/remoteinstaller/remoteinstallerdialog.h <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>publisher/remoteinstaller/remoteinstallerdialog.cpp <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>publisher/remoteinstaller/standalone/main.cpp <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>publisher/remoteinstaller/standalone/plasmaremoteinstaller.h <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>publisher/remoteinstaller/standalone/plasmaremoteinstaller.cpp <span \
style="color: grey">(PRE-CREATION)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/105032/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic