'Re: Review Request: Plasmate: request to merge terietor/remoteinstaller to master'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    Re: Review Request: Plasmate: request to merge terietor/remoteinstaller to master
From:       "David Edmundson" <kde () davidedmundson ! co ! uk>
Date:       2012-06-02 15:14:48
Message-ID: 20120602151448.21493.17594 () vidsolbach ! de
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105032/#review14379
-----------------------------------------------------------

Looks good to me (though I'm not too involved in plasma, so I won't click s=
hip it).
I have a several nitpicking issues below.

Also if you're making a new app make sure to check with someone if you need=
 a Messages.sh file.

publisher/publisher.cpp
<http://git.reviewboard.kde.org/r/105032/#comment11344>

    Be sure to add your name to the copyright notices when you make large c=
hange. Though in reality everyone forgets to do this :)

publisher/remoteinstaller/remoteinstaller.h
<http://git.reviewboard.kde.org/r/105032/#comment11345>

    Unless there's a good reason, use KUrl
    =

    (and for the other url in this class)

publisher/remoteinstaller/remoteinstaller.cpp
<http://git.reviewboard.kde.org/r/105032/#comment11346>

    Is this display hack needed with the newly patched plasmapkg?

publisher/remoteinstaller/remoteinstallerdialog.cpp
<http://git.reviewboard.kde.org/r/105032/#comment11347>

    Normalise these.
    (i.e remove the consts and &'s)
    you don't need them when specifying the method in 'connect'
    =

    http://marcmutz.wordpress.com/effective-qt/prefer-to-use-normalised-sig=
nalslot-signatures/
    =

    =

publisher/remoteinstaller/remoteinstallerdialog.cpp
<http://git.reviewboard.kde.org/r/105032/#comment11349>

    This looks like it leaks.
    =

    QScopedPointer perhaps?

publisher/remoteinstaller/remoteinstallerdialog.cpp
<http://git.reviewboard.kde.org/r/105032/#comment11350>

    Why is this needed? When you create m_installer, you pass this as the p=
arent. =

    =

publisher/remoteinstaller/remoteinstallerdialog.cpp
<http://git.reviewboard.kde.org/r/105032/#comment11351>

    for single characters use ' ' rather than " ".
    =

    That way Qt knows to search for a character (rather than a string which=
 just happens to be one letter long) and uses a faster replace method.

- David Edmundson

On June 1, 2012, 6:11 p.m., Giorgos Tsiapaliwkas wrote:
> =

> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/105032/
> -----------------------------------------------------------
> =

> (Updated June 1, 2012, 6:11 p.m.)
> =

> =

> Review request for Plasma.
> =

> =

> Description
> -------
> =

> Hello,
> =

> in terietor/remoteinstaller I have create a remote installer.
> The goal is to install the projects remotely to another computer.
> =

> You access the remote install either inside plasmate or using the plasmar=
emoteinstaller binary.
> =

> =

> Diffs
> -----
> =

>   CMakeLists.txt 12f8a3a =

>   publisher/publisher.h 5f40ae0 =

>   publisher/publisher.cpp fd87364 =

>   publisher/remoteinstaller/advancedmodewidget.ui PRE-CREATION =

>   publisher/remoteinstaller/remoteinstaller.h PRE-CREATION =

>   publisher/remoteinstaller/remoteinstaller.cpp PRE-CREATION =

>   publisher/remoteinstaller/remoteinstaller.ui PRE-CREATION =

>   publisher/remoteinstaller/remoteinstallerdialog.h PRE-CREATION =

>   publisher/remoteinstaller/remoteinstallerdialog.cpp PRE-CREATION =

>   publisher/remoteinstaller/standalone/main.cpp PRE-CREATION =

>   publisher/remoteinstaller/standalone/plasmaremoteinstaller.h PRE-CREATI=
ON =

>   publisher/remoteinstaller/standalone/plasmaremoteinstaller.cpp PRE-CREA=
TION =

> =

> Diff: http://git.reviewboard.kde.org/r/105032/diff/
> =

> =

> Testing
> -------
> =

> I couldn't find any bugs in the remote installer, but the proccess fails =
during KIO::copy.
> Apparently I am not writing correct something in the fish protocol.
> Right now the remote installer tries to do the above
> =

> KIO::copy("/home/terietor/.kde4/share/apps/plasmate/project, "fish://user=
@ip/home/user")
> =

> but it fails
> =

> =

> Thanks,
> =

> Giorgos Tsiapaliwkas
> =

>

[Attachment #5 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="http://git.reviewboard.kde.org/r/105032/">http://git.reviewboard.kde.org/r/105032/</a>
  </td>
    </tr>
   </table>
   <br />

 <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Looks good to me (though \
I&#39;m not too involved in plasma, so I won&#39;t click ship it). I have a several \
nitpicking issues below.

Also if you&#39;re making a new app make sure to check with someone if you need a \
Messages.sh file.</pre>  <br />

<div>

<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;">  <thead>
  <tr>
   <th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;">  <a \
href="http://git.reviewboard.kde.org/r/105032/diff/3/?file=66051#file66051line2" \
style="color: black; font-weight: bold; text-decoration: \
underline;">publisher/publisher.cpp</a>  <span style="font-weight: normal;">

     (Diff revision 3)

    </span>
   </th>
  </tr>
 </thead>

 <tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
  <tr>

   <td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; \
"></pre></td>

  </tr>
 </tbody>

 <tbody>

  <tr>
    <th bgcolor="#f0f0f0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2">2</font></th>  <td bgcolor="#ffffff" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "><span class="cm">  Copyright \
2009 Lim Yuen Hoe &lt;yuenhoe@hotmail.com&gt;</span></pre></td>  <th \
bgcolor="#f0f0f0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">2</font></th>  <td bgcolor="#ffffff" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span \
class="cm">  Copyright 2009 Lim Yuen Hoe \
&lt;yuenhoe@hotmail.com&gt;</span></pre></td>  </tr>

 </tbody>

</table>

<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Be sure to \
add your name to the copyright notices when you make large change. Though in reality \
everyone forgets to do this :)</pre> </div>
<br />

<div>

<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;">  <thead>
  <tr>
   <th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;">  <a \
href="http://git.reviewboard.kde.org/r/105032/diff/3/?file=66053#file66053line31" \
style="color: black; font-weight: bold; text-decoration: \
underline;">publisher/remoteinstaller/remoteinstaller.h</a>  <span \
style="font-weight: normal;">

     (Diff revision 3)

    </span>
   </th>
  </tr>
 </thead>

 <tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
  <tr>

   <td colspan="2"><pre style="font-size: 8pt; line-height: 140%; margin: 0; \
"></pre></td>  <td colspan="2"><pre style="font-size: 8pt; line-height: 140%; margin: \
0; ">private:</pre></td>

  </tr>
 </tbody>

 <tbody>

  <tr>
    <th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th>  <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>  <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">31</font></th>  <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">    <span \
class="n">QUrl</span> <span class="n">m_execUrl</span><span \
class="p">;</span></pre></td>  </tr>

 </tbody>

</table>

<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Unless \
there&#39;s a good reason, use KUrl

(and for the other url in this class)</pre>
</div>
<br />

<div>

<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;">  <thead>
  <tr>
   <th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;">  <a \
href="http://git.reviewboard.kde.org/r/105032/diff/3/?file=66054#file66054line54" \
style="color: black; font-weight: bold; text-decoration: \
underline;">publisher/remoteinstaller/remoteinstaller.cpp</a>  <span \
style="font-weight: normal;">

     (Diff revision 3)

    </span>
   </th>
  </tr>
 </thead>

 <tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
  <tr>

   <td colspan="2"><pre style="font-size: 8pt; line-height: 140%; margin: 0; \
"></pre></td>  <td colspan="2"><pre style="font-size: 8pt; line-height: 140%; margin: \
0; ">RemoteInstaller::RemoteInstaller(const QString&amp; username, const QString&amp; \
hostname,</pre></td>

  </tr>
 </tbody>

 <tbody>

  <tr>
    <th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th>  <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>  <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">54</font></th>  <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">    <span \
class="n">KConfigGroup</span> <span class="n">c</span><span class="p">(</span><span \
class="n">KGlobal</span><span class="o">::</span><span class="n">config</span><span \
class="p">(),</span> <span class="s">&quot;RemoteInstaller&quot;</span><span \
class="p">);</span></pre></td>  </tr>

 </tbody>

</table>

<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Is this \
display hack needed with the newly patched plasmapkg?</pre> </div>
<br />

<div>

<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;">  <thead>
  <tr>
   <th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;">  <a \
href="http://git.reviewboard.kde.org/r/105032/diff/3/?file=66057#file66057line38" \
style="color: black; font-weight: bold; text-decoration: \
underline;">publisher/remoteinstaller/remoteinstallerdialog.cpp</a>  <span \
style="font-weight: normal;">

     (Diff revision 3)

    </span>
   </th>
  </tr>
 </thead>

 <tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
  <tr>

   <td colspan="2"><pre style="font-size: 8pt; line-height: 140%; margin: 0; \
"></pre></td>  <td colspan="2"><pre style="font-size: 8pt; line-height: 140%; margin: \
0; ">RemoteInstallerDialog::RemoteInstallerDialog(QWidget* parent)</pre></td>

  </tr>
 </tbody>

 <tbody>

  <tr>
    <th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th>  <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>  <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">38</font></th>  <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">    <span \
class="n">connect</span><span class="p">(</span><span class="n">m_ui</span><span \
class="p">.</span><span class="n">usernameLineEdit</span><span class="p">,</span> \
<span class="n">SIGNAL</span><span class="p">(</span><span \
class="n">textChanged</span><span class="p">(</span><span class="k">const</span> \
<span class="n">QString</span><span class="o">&amp;</span><span class="p">)),</span> \
<span class="k">this</span><span class="p">,</span> <span class="n">SLOT</span><span \
class="p">(</span><span class="n">checkInformations</span><span \
class="p">()));</span></pre></td>  </tr>

 </tbody>

</table>

<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Normalise \
these. (i.e remove the consts and &amp;&#39;s)
you don&#39;t need them when specifying the method in &#39;connect&#39;

http://marcmutz.wordpress.com/effective-qt/prefer-to-use-normalised-signalslot-signatures/

</pre>
</div>
<br />

<div>

<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;">  <thead>
  <tr>
   <th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;">  <a \
href="http://git.reviewboard.kde.org/r/105032/diff/3/?file=66057#file66057line53" \
style="color: black; font-weight: bold; text-decoration: \
underline;">publisher/remoteinstaller/remoteinstallerdialog.cpp</a>  <span \
style="font-weight: normal;">

     (Diff revision 3)

    </span>
   </th>
  </tr>
 </thead>

 <tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
  <tr>

   <td colspan="2"><pre style="font-size: 8pt; line-height: 140%; margin: 0; \
"></pre></td>  <td colspan="2"><pre style="font-size: 8pt; line-height: 140%; margin: \
0; ">RemoteInstallerDialog::RemoteInstallerDialog(QWidget* parent)</pre></td>

  </tr>
 </tbody>

 <tbody>

  <tr>
    <th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th>  <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>  <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">53</font></th>  <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">    <span \
class="n">QPointer</span><span class="o">&lt;</span><span \
class="n">KDialog</span><span class="o">&gt;</span> <span class="n">dialog</span> \
<span class="o">=</span> <span class="k">new</span> <span \
class="n">KDialog</span><span class="p">(</span><span class="k">this</span><span \
class="p">);</span></pre></td>  </tr>

 </tbody>

</table>

<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This looks \
like it leaks.

QScopedPointer perhaps?</pre>
</div>
<br />

<div>

<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;">  <thead>
  <tr>
   <th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;">  <a \
href="http://git.reviewboard.kde.org/r/105032/diff/3/?file=66057#file66057line80" \
style="color: black; font-weight: bold; text-decoration: \
underline;">publisher/remoteinstaller/remoteinstallerdialog.cpp</a>  <span \
style="font-weight: normal;">

     (Diff revision 3)

    </span>
   </th>
  </tr>
 </thead>

 <tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
  <tr>

   <td colspan="2"><pre style="font-size: 8pt; line-height: 140%; margin: 0; \
"></pre></td>  <td colspan="2"><pre style="font-size: 8pt; line-height: 140%; margin: \
0; ">RemoteInstallerDialog::RemoteInstallerDialog(QWidget* parent)</pre></td>

  </tr>
 </tbody>

 <tbody>

  <tr>
    <th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th>  <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>  <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">80</font></th>  <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">    <span \
class="k">delete</span> <span class="n">m_installer</span><span \
class="p">;</span></pre></td>  </tr>

 </tbody>

</table>

<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Why is this \
needed? When you create m_installer, you pass this as the parent.  </pre>
</div>
<br />

<div>

<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;">  <thead>
  <tr>
   <th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;">  <a \
href="http://git.reviewboard.kde.org/r/105032/diff/3/?file=66057#file66057line94" \
style="color: black; font-weight: bold; text-decoration: \
underline;">publisher/remoteinstaller/remoteinstallerdialog.cpp</a>  <span \
style="font-weight: normal;">

     (Diff revision 3)

    </span>
   </th>
  </tr>
 </thead>

 <tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
  <tr>

   <td colspan="2"><pre style="font-size: 8pt; line-height: 140%; margin: 0; \
"></pre></td>  <td colspan="2"><pre style="font-size: 8pt; line-height: 140%; margin: \
0; ">RemoteInstallerDialog::RemoteInstallerDialog(QWidget* parent)</pre></td>

  </tr>
 </tbody>

 <tbody>

  <tr>
    <th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th>  <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>  <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">94</font></th>  <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">    <span \
class="n">hostname</span> <span class="o">=</span> <span \
class="n">hostname</span><span class="p">.</span><span class="n">replace</span><span \
class="p">(</span><span class="s">&quot; &quot;</span><span class="p">,</span> <span \
class="s">&quot;&quot;</span><span class="p">);</span></pre></td>  </tr>

 </tbody>

</table>

<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">for single \
characters use &#39; &#39; rather than &quot; &quot;.

That way Qt knows to search for a character (rather than a string which just happens \
to be one letter long) and uses a faster replace method.</pre> </div>
<br />

<p>- David</p>

<br />
<p>On June 1st, 2012, 6:11 p.m., Giorgos Tsiapaliwkas wrote:</p>

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;">  <tr>
  <td>

<div>Review request for Plasma.</div>
<div>By Giorgos Tsiapaliwkas.</div>

<p style="color: grey;"><i>Updated June 1, 2012, 6:11 p.m.</i></p>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Hello,

in terietor/remoteinstaller I have create a remote installer.
The goal is to install the projects remotely to another computer.

You access the remote install either inside plasmate or using the \
plasmaremoteinstaller binary.</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">I couldn&#39;t find any bugs in the remote installer, but the proccess \
fails during KIO::copy. Apparently I am not writing correct something in the fish \
protocol. Right now the remote installer tries to do the above

KIO::copy(&quot;/home/terietor/.kde4/share/apps/plasmate/project, \
&quot;fish://user@ip/home/user&quot;)

but it fails
</pre>
  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>CMakeLists.txt <span style="color: grey">(12f8a3a)</span></li>

 <li>publisher/publisher.h <span style="color: grey">(5f40ae0)</span></li>

 <li>publisher/publisher.cpp <span style="color: grey">(fd87364)</span></li>

 <li>publisher/remoteinstaller/advancedmodewidget.ui <span style="color: \
grey">(PRE-CREATION)</span></li>

 <li>publisher/remoteinstaller/remoteinstaller.h <span style="color: \
grey">(PRE-CREATION)</span></li>

 <li>publisher/remoteinstaller/remoteinstaller.cpp <span style="color: \
grey">(PRE-CREATION)</span></li>

 <li>publisher/remoteinstaller/remoteinstaller.ui <span style="color: \
grey">(PRE-CREATION)</span></li>

 <li>publisher/remoteinstaller/remoteinstallerdialog.h <span style="color: \
grey">(PRE-CREATION)</span></li>

 <li>publisher/remoteinstaller/remoteinstallerdialog.cpp <span style="color: \
grey">(PRE-CREATION)</span></li>

 <li>publisher/remoteinstaller/standalone/main.cpp <span style="color: \
grey">(PRE-CREATION)</span></li>

 <li>publisher/remoteinstaller/standalone/plasmaremoteinstaller.h <span style="color: \
grey">(PRE-CREATION)</span></li>

 <li>publisher/remoteinstaller/standalone/plasmaremoteinstaller.cpp <span \
style="color: grey">(PRE-CREATION)</span></li>

</ul>

<p><a href="http://git.reviewboard.kde.org/r/105032/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[prev in list] [next in list] [prev in thread] [next in thread] 