[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-panel-devel
Subject: Re: Review Request: Plasmate: Add Tabbox support to the startpage
From: Martin_Gräßlin <kde () martin-graesslin ! com>
Date: 2012-06-01 13:41:35
Message-ID: 20120601134135.5970.73508 () vidsolbach ! de
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105011/#review14324
-----------------------------------------------------------
the template is still wrong, apart from that I would say it looks fine.
- Martin Gr=C3=A4=C3=9Flin
On May 30, 2012, 3:43 p.m., Antonis Tsiapaliokas wrote:
> =
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/105011/
> -----------------------------------------------------------
> =
> (Updated May 30, 2012, 3:43 p.m.)
> =
> =
> Review request for kwin, Plasma and Martin Gr=C3=A4=C3=9Flin.
> =
> =
> Description
> -------
> =
> Hello,
> =
> This is the first task of my GSoC. I have add the tabbox support to the s=
tartpage of the plasmate.
> =
> NOTES:
> =
> 1)The service type of the tabbox is "Kwin/Tabbox,Plasma/Applet", because =
the Plasma::PackageStructure requires the "Plasma/Applet" in order to be ab=
le to be used. Also the plasmapkg and the plasmoidview require the "Plasma/=
Applet" service type.
> 2)Some lines doesn't have any differences because i have remove some whit=
espaces and "tabs"... =
> =
> ISSUES:
> =
> 1)The icons for the tabbox are wrong. I have some issues with my PCs and =
i cannot open a new session of the KDE.
> So i wasn't able to find the icon. Sorry for that.
> 2)The template of the tabbox that i have put is located in the kde-worksp=
ace/kwin/kcmkwin/kwintabbox/qml/main.qml. The main.qml cannot be installed =
becuase it uses some Q_PROPERTY elements. Any ideas about how to fix that?
> 3)I think that the starting comments of the tabbox should become better. =
I would prefer something like the "mainPlasmoid.qml"....
> =
> =
> Diffs
> -----
> =
> editors/metadata/metadataeditor.cpp fce65fd =
> startpage.h 0df4c21 =
> startpage.cpp 9774b48 =
> templates/CMakeLists.txt 6a82772 =
> templates/mainTabbox.qml PRE-CREATION =
> =
> Diff: http://git.reviewboard.kde.org/r/105011/diff/
> =
> =
> Testing
> -------
> =
> =
> Screenshots
> -----------
> =
> =
> http://git.reviewboard.kde.org/r/105011/s/574/
> =
> =
> Thanks,
> =
> Antonis Tsiapaliokas
> =
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/105011/">http://git.reviewboard.kde.org/r/105011/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">the template is still \
wrong, apart from that I would say it looks fine.</pre> <br />
<p>- Martin</p>
<br />
<p>On May 30th, 2012, 3:43 p.m., Antonis Tsiapaliokas wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for kwin, Plasma and Martin Gräßlin.</div>
<div>By Antonis Tsiapaliokas.</div>
<p style="color: grey;"><i>Updated May 30, 2012, 3:43 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Hello,
This is the first task of my GSoC. I have add the tabbox support to the startpage of \
the plasmate.
NOTES:
1)The service type of the tabbox is "Kwin/Tabbox,Plasma/Applet", because \
the Plasma::PackageStructure requires the "Plasma/Applet" in order to be \
able to be used. Also the plasmapkg and the plasmoidview require the \
"Plasma/Applet" service type. 2)Some lines doesn't have any differences \
because i have remove some whitespaces and "tabs"...
ISSUES:
1)The icons for the tabbox are wrong. I have some issues with my PCs and i cannot \
open a new session of the KDE. So i wasn't able to find the icon. Sorry for that.
2)The template of the tabbox that i have put is located in the \
kde-workspace/kwin/kcmkwin/kwintabbox/qml/main.qml. The main.qml cannot be installed \
becuase it uses some Q_PROPERTY elements. Any ideas about how to fix that? 3)I think \
that the starting comments of the tabbox should become better. I would prefer \
something like the "mainPlasmoid.qml"....
</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>editors/metadata/metadataeditor.cpp <span style="color: \
grey">(fce65fd)</span></li>
<li>startpage.h <span style="color: grey">(0df4c21)</span></li>
<li>startpage.cpp <span style="color: grey">(9774b48)</span></li>
<li>templates/CMakeLists.txt <span style="color: grey">(6a82772)</span></li>
<li>templates/mainTabbox.qml <span style="color: grey">(PRE-CREATION)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/105011/diff/" style="margin-left: \
3em;">View Diff</a></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Screenshots </h1>
<div>
<a href="http://git.reviewboard.kde.org/r/105011/s/574/"><img \
src="http://git.reviewboard.kde.org/media/uploaded/images/2012/05/22/tabbox_400x100.png" \
style="border: 1px black solid;" alt="" /></a>
</div>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic