From kde-panel-devel Thu May 31 21:18:24 2012 From: "Seif Lotfy" Date: Thu, 31 May 2012 21:18:24 +0000 To: kde-panel-devel Subject: Re: Review Request: kickoff: save recent applications list on every change to it Message-Id: <20120531211824.24515.98403 () vidsolbach ! de> X-MARC-Message: https://marc.info/?l=kde-panel-devel&m=133850025110955 MIME-Version: 1 Content-Type: multipart/mixed; boundary="--===============4005287499404380909==" --===============4005287499404380909== Content-Type: multipart/alternative; boundary="===============4003682874881945483==" --===============4003682874881945483== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable > On May 31, 2012, 10:09 a.m., Aaron J. Seigo wrote: > > the real fubar here is that it stores this information internally in it= s own config file. this really ought to be stored/retrieved from nepomuk an= d/or zeitgeist. > > = > > i've cc'd Trever on this because he may have something to say about tha= t as well. > = > Trever Fischer wrote: > I actually just recently patched Dragon to do so, and it took very fe= w lines: http://quickgit.kde.org/index.php?p=3Ddragon.git&a=3Dcommitdiff&h= =3D92fb6296e424dc829e0c5cc541aa3581856d2098 > = > Since Kickoff uses QAbstractItemModels, switching things to use a QZe= itgeist::LogModel should be trivial. Alternatively, implementing the Recent= Applications class to use Zeitgeist can be trivial as well, and would seem = like the easiest way to do things. > = > Aaron J. Seigo wrote: > if we could dump RecentApplications that'd be great. there's not much= reason to go through a local class just to get to another library (qzeitge= ist) class. then the LogModel can be used in the RecentlyUsedModel .. = > = > in fact, if KRecentDocument in kdelibs/kio/kfile/ were made to use ze= itgeist, i bet we could just drop the RecentlyUsedModel altogether, or at w= orst have it as a thin layer around LogModel (don't know what LogModel prov= ides, so I can't really offer a concrete suggestion there). that sounds lik= e frameworks 5 work, though, so we'll have to just hold off on that for kic= koff .. but would seem to be the natural progression and something that cou= ld implemented immediately in the frameworks branch in any case... > = > Trever Fischer wrote: > logmodel.h: http://quickgit.kde.org/index.php?p=3Dlibqzeitgeist.git&a= =3Dblob&h=3D2ef6bfac0ab917ed5508da64b3a9d1a9290e65e6&hb=3Da58d1caaa953b514b= 7bd1697c44aebf75b11829d&f=3Dsrc%2Flogmodel.h > = > It provides a bunch of shortcuts for access to the underlying event o= bject data, or you can access the event in its entirety. > = > What it doesn't provide that the recentlyusedmodel provides is the im= mediate ability to remove events. You'd need to grab the event and then ask= a Log object to delete it from the database. I am considering adding that = API to the 0.10 release. > = > Ivan =C4=8Cuki=C4=87 wrote: > Another thing for these types of models that we *need* to start addin= g is the support for different results based on the activity. > = > Has Zeitgeist moved in that direction as promised before (in Randa)? This is supported. Just attach the id of the activity to the event.origin. = You can then query Zeitgeist with event.origin set to the activity id and i= t will return only results based on events that happened in that activity - Seif ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105112/#review14293 ----------------------------------------------------------- On May 31, 2012, 10:08 a.m., Andriy Gapon wrote: > = > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/105112/ > ----------------------------------------------------------- > = > (Updated May 31, 2012, 10:08 a.m.) > = > = > Review request for Plasma and Trever Fischer. > = > = > Description > ------- > = > Currently recent applications list in kickoff is saved only when kickoff = gracefully exits. This could be a minor annoyance when X/KDE/plasma crashe= s. I think that saving the list on every update to it should be a good ide= a. It should be a low overhead too, because the list changes only when a u= ser launches an application via KDE. > = > = > This addresses bug 206511. > http://bugs.kde.org/show_bug.cgi?id=3D206511 > = > = > Diffs > ----- > = > plasma/desktop/applets/kickoff/core/recentapplications.cpp 3e05389 = > = > Diff: http://git.reviewboard.kde.org/r/105112/diff/ > = > = > Testing > ------- > = > = > Thanks, > = > Andriy Gapon > = > --===============4003682874881945483== Content-Type: text/html; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable
This is an automatically generated e-mail. To reply, visit: http://git.revie= wboard.kde.org/r/105112/

On May 31st, 2012, 10:09 a.m., Aaron J. Sei= go wrote:

the real =
fubar here is that it stores this information internally in its own config =
file. this really ought to be stored/retrieved from nepomuk and/or zeitgeis=
t.

i've cc'd Trever on this because he may have something to say about=
 that as well.

On May 31st, 2012, 1:37 p.m., Trever Fischer wrote:

I actuall=
y just recently patched Dragon to do so, and it took very few lines: http:/=
/quickgit.kde.org/index.php?p=3Ddragon.git&a=3Dcommitdiff&h=3D92fb6=
296e424dc829e0c5cc541aa3581856d2098

Since Kickoff uses QAbstractItemModels, switching things to use a QZeitgeis=
t::LogModel should be trivial. Alternatively, implementing the RecentApplic=
ations class to use Zeitgeist can be trivial as well, and would seem like t=
he easiest way to do things.

On May 31st, 2012, 2:43 p.m., Aaron J. Seigo wrote:

if we cou=
ld dump RecentApplications that'd be great. there's not much reason=
 to go through a local class just to get to another library (qzeitgeist) cl=
ass. then the LogModel can be used in the RecentlyUsedModel .. =


in fact, if KRecentDocument in kdelibs/kio/kfile/ were made to use zeitgeis=
t, i bet we could just drop the RecentlyUsedModel altogether, or at worst h=
ave it as a thin layer around LogModel (don't know what LogModel provid=
es, so I can't really offer a concrete suggestion there). that sounds l=
ike frameworks 5 work, though, so we'll have to just hold off on that f=
or kickoff .. but would seem to be the natural progression and something th=
at could implemented immediately in the frameworks branch in any case...
 

On May 31st, 2012, 4:36 p.m., Trever Fischer wrote:

logmodel.=
h: http://quickgit.kde.org/index.php?p=3Dlibqzeitgeist.git&a=3Dblob&=
;h=3D2ef6bfac0ab917ed5508da64b3a9d1a9290e65e6&hb=3Da58d1caaa953b514b7bd=
1697c44aebf75b11829d&f=3Dsrc%2Flogmodel.h

It provides a bunch of shortcuts for access to the underlying event object =
data, or you can access the event in its entirety.

What it doesn't provide that the recentlyusedmodel provides is the imme=
diate ability to remove events. You'd need to grab the event and then a=
sk a Log object to delete it from the database. I am considering adding tha=
t API to the 0.10 release.

On May 31st, 2012, 4:45 p.m., Ivan =C4=8Cuki=C4=87 wrote:

Another t=
hing for these types of models that we *need* to start adding is the suppor=
t for different results based on the activity.

Has Zeitgeist moved in that direction as promised before (in Randa)?
This is sup=
ported. Just attach the id of the activity to the event.origin. You can the=
n query Zeitgeist with event.origin set to the activity id and it will retu=
rn only results based on events that happened in that activity

- Seif


On May 31st, 2012, 10:08 a.m., Andriy Gapon wrote:

Review request for Plasma and Trever Fischer.
By Andriy Gapon.

Updated May 31, 2012, 10:08 a.m.

Descripti= on

Currently recent applications list in kickoff is saved only =
when kickoff gracefully exits.  This could be a minor annoyance when X/KDE/=
plasma crashes.  I think that saving the list on every update to it should =
be a good idea.  It should be a low overhead too, because the list changes =
only when a user launches an application via KDE.
Bugs: 206511

Diffs=

  • plasma/desktop/applets/kickoff/core/recentapplications.cpp (3e05389)

View Diff

--===============4003682874881945483==-- --===============4005287499404380909== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel --===============4005287499404380909==--