--===============2110354438696522693== Content-Type: multipart/alternative; boundary="===============3696047163038149621==" --===============3696047163038149621== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105011/ ----------------------------------------------------------- (Updated May 30, 2012, 3:43 p.m.) Review request for kwin, Plasma and Martin Gr=C3=A4=C3=9Flin. Changes ------- The whitespaces and the tabs have been removed from the patch, because Aaro= n has fix that with his latest patch on plasmate Description ------- Hello, This is the first task of my GSoC. I have add the tabbox support to the sta= rtpage of the plasmate. NOTES: 1)The service type of the tabbox is "Kwin/Tabbox,Plasma/Applet", because th= e Plasma::PackageStructure requires the "Plasma/Applet" in order to be able= to be used. Also the plasmapkg and the plasmoidview require the "Plasma/Ap= plet" service type. 2)Some lines doesn't have any differences because i have remove some whites= paces and "tabs"... = ISSUES: 1)The icons for the tabbox are wrong. I have some issues with my PCs and i = cannot open a new session of the KDE. So i wasn't able to find the icon. Sorry for that. 2)The template of the tabbox that i have put is located in the kde-workspac= e/kwin/kcmkwin/kwintabbox/qml/main.qml. The main.qml cannot be installed be= cuase it uses some Q_PROPERTY elements. Any ideas about how to fix that? 3)I think that the starting comments of the tabbox should become better. I = would prefer something like the "mainPlasmoid.qml".... Diffs (updated) ----- editors/metadata/metadataeditor.cpp fce65fd = startpage.h 0df4c21 = startpage.cpp 9774b48 = templates/CMakeLists.txt 6a82772 = templates/mainTabbox.qml PRE-CREATION = Diff: http://git.reviewboard.kde.org/r/105011/diff/ Testing ------- Screenshots ----------- http://git.reviewboard.kde.org/r/105011/s/574/ Thanks, Antonis Tsiapaliokas --===============3696047163038149621== Content-Type: text/html; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable
This is an automatically generated e-mail. To reply, visit: http://git.revie= wboard.kde.org/r/105011/ |
Review request for kwin, Plasma and Martin Gr=C3=A4=C3=9Flin.
By Antonis Tsiapaliokas.
Updated May 30, 2012, 3:43 p.m. Changes= h1>
Descripti= on
Diffs= (updated)
Screensho= ts |