From kde-panel-devel Tue May 29 15:44:04 2012 From: "Commit Hook" Date: Tue, 29 May 2012 15:44:04 +0000 To: kde-panel-devel Subject: Re: Review Request: SortFilterModel: Do not reset model while changing the regexp Message-Id: <20120529154404.5299.19293 () vidsolbach ! de> X-MARC-Message: https://marc.info/?l=kde-panel-devel&m=133830644105457 MIME-Version: 1 Content-Type: multipart/mixed; boundary="--===============9173365835487813851==" --===============9173365835487813851== Content-Type: multipart/alternative; boundary="===============7684420079630356256==" --===============7684420079630356256== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105042/#review14269 ----------------------------------------------------------- This review has been submitted with commit 03ecbc135a85939efcdc254b29becfdd= 0940e659 by Aur=C3=A9lien G=C3=A2teau to branch master. - Commit Hook On May 25, 2012, 2:40 p.m., Aur=C3=A9lien G=C3=A2teau wrote: > = > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/105042/ > ----------------------------------------------------------- > = > (Updated May 25, 2012, 2:40 p.m.) > = > = > Review request for Plasma. > = > = > Description > ------- > = > SortFilterModel::setRegExp() calls beginResetModel() before setting the r= egexp and endResetModel() when done. This cause flickering as the QML view = must refresh its entire content. QSortFilterProxyModel correctly add or rem= ove rows when filtering, so resetting the model is not necessary. > = > = > Diffs > ----- > = > plasma/declarativeimports/core/datamodel.cpp 97d129e = > = > Diff: http://git.reviewboard.kde.org/r/105042/diff/ > = > = > Testing > ------- > = > Test script attached demonstrates the problem by having a delegate whose = opacity goes from 0 to 1 when completed. > = > - Download regexp-flicker.{pro,cpp,qml} > - run qmake ; make > - Type in the input field =3D> without the patch, remaining items flicker= . With the patch they do not because they are not recreated. > = > = > Thanks, > = > Aur=C3=A9lien G=C3=A2teau > = > --===============7684420079630356256== Content-Type: text/html; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable
This is an automatically generated e-mail. To reply, visit: http://git.revie= wboard.kde.org/r/105042/ 

This revie=
w has been submitted with commit 03ecbc135a85939efcdc254b29becfdd0940e659 b=
y Aur=C3=A9lien G=C3=A2teau to branch master.

- Commit


On May 25th, 2012, 2:40 p.m., Aur=C3=A9lien G=C3=A2teau wrote:

Review request for Plasma.
By Aur=C3=A9lien G=C3=A2teau.

Updated May 25, 2012, 2:40 p.m.

Descripti= on 

SortFilterModel::setRegExp() calls beginResetModel() before =
setting the regexp and endResetModel() when done. This cause flickering as =
the QML view must refresh its entire content. QSortFilterProxyModel correct=
ly add or remove rows when filtering, so resetting the model is not necessa=
ry.

Testing <= /h1> 
Test script attached demonstrates the problem by having a de=
legate whose opacity goes from 0 to 1 when completed.

- Download regexp-flicker.{pro,cpp,qml}
- run qmake ; make
- Type in the input field =3D> without the patch, remaining items flicke=
r. With the patch they do not because they are not recreated.

Diffs=

  • plasma/declarativeimports/core/datamodel.cpp (97d129e)

View Diff
--===============7684420079630356256==-- --===============9173365835487813851== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel --===============9173365835487813851==--