--===============8530446272353940710== Content-Type: multipart/alternative; boundary="===============6739290732444643322==" --===============6739290732444643322== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105031/#review14231 ----------------------------------------------------------- Ship it! Ship It! - Aaron J. Seigo On May 24, 2012, 5:31 p.m., Giorgos Tsiapaliwkas wrote: > = > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/105031/ > ----------------------------------------------------------- > = > (Updated May 24, 2012, 5:31 p.m.) > = > = > Review request for Plasma. > = > = > Description > ------- > = > Hello, > = > I ported Publisher to a ui file and I added an install action as sebas pr= oposed. > = > = > Diffs > ----- > = > CMakeLists.txt 7e1bf4b = > mainwindow.h bd4d376 = > mainwindow.cpp 4728894 = > plasmateui.rc 9123298 = > publisher/publisher.h ee57cf3 = > publisher/publisher.cpp 11ddf36 = > = > Diff: http://git.reviewboard.kde.org/r/105031/diff/ > = > = > Testing > ------- > = > When I active the install project action the Publisher::doPublish() is ca= lled. > This mustn't happen. > = > Also I am don't know which shortcut to choose. > = > = > Thanks, > = > Giorgos Tsiapaliwkas > = > --===============6739290732444643322== Content-Type: text/html; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable
This is an automatically generated e-mail. To reply, visit: http://git.revie= wboard.kde.org/r/105031/

Ship it!

Ship It!
 

- Aaron J.


On May 24th, 2012, 5:31 p.m., Giorgos Tsiapaliwkas wrote:

Review request for Plasma.
By Giorgos Tsiapaliwkas.

Updated May 24, 2012, 5:31 p.m.

Descripti= on

Hello,

I ported Publisher to a ui file and I added an install action as sebas prop=
osed.

Testing <= /h1>
When I active the install project action the Publisher::doPu=
blish() is called.
This mustn't happen.

Also I am don't know which shortcut to choose.

Diffs=

  • CMakeLists.txt (7e1bf4b)
  • mainwindow.h (bd4d376)
  • mainwindow.cpp (4728894)
  • plasmateui.rc (9123298)
  • publisher/publisher.h (ee57cf3)
  • publisher/publisher.cpp (11ddf36)

View Diff

--===============6739290732444643322==-- --===============8530446272353940710== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel --===============8530446272353940710==--