[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-panel-devel
Subject: Re: Review Request: Plasmate: port Publisher to a ui file and add an install action
From: "Aaron J. Seigo" <aseigo () kde ! org>
Date: 2012-05-28 13:13:41
Message-ID: 20120528131341.28432.12616 () vidsolbach ! de
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
> On May 27, 2012, 6:43 p.m., Aaron J. Seigo wrote:
> > is the "testing done" comment about doPublish being called still correc=
t? i don't see how it could be? :)
> =
> Giorgos Tsiapaliwkas wrote:
> > i don't see how it could be? :)
> =
> You have right it doesn't. That's my fault.
> I just noticed that in the publish dialog that I had enabled the "Ena=
ble Signing Plasmoid".
> So when the doPlasmaPkg was called the singing dialog was also called.
> =
> So the patch is fine. Should I commit it?
> =
> P.S.: I still need a shortcut for the install action. What do you wan=
t me to put there?
it does't require a shortcut; though Ctrl+I seems sane to me...
- Aaron J.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105031/#review14211
-----------------------------------------------------------
On May 24, 2012, 5:31 p.m., Giorgos Tsiapaliwkas wrote:
> =
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/105031/
> -----------------------------------------------------------
> =
> (Updated May 24, 2012, 5:31 p.m.)
> =
> =
> Review request for Plasma.
> =
> =
> Description
> -------
> =
> Hello,
> =
> I ported Publisher to a ui file and I added an install action as sebas pr=
oposed.
> =
> =
> Diffs
> -----
> =
> CMakeLists.txt 7e1bf4b =
> mainwindow.h bd4d376 =
> mainwindow.cpp 4728894 =
> plasmateui.rc 9123298 =
> publisher/publisher.h ee57cf3 =
> publisher/publisher.cpp 11ddf36 =
> =
> Diff: http://git.reviewboard.kde.org/r/105031/diff/
> =
> =
> Testing
> -------
> =
> When I active the install project action the Publisher::doPublish() is ca=
lled.
> This mustn't happen.
> =
> Also I am don't know which shortcut to choose.
> =
> =
> Thanks,
> =
> Giorgos Tsiapaliwkas
> =
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/105031/">http://git.reviewboard.kde.org/r/105031/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <p style="margin-top: 0;">On May 27th, 2012, 6:43 p.m., <b>Aaron J. \
Seigo</b> wrote:</p> <blockquote style="margin-left: 1em; border-left: 2px solid \
#d0d0d0; padding-left: 10px;"> <pre style="white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">is the "testing done" comment about doPublish being called \
still correct? i don't see how it could be? :)</pre> </blockquote>
<p>On May 28th, 2012, 7:30 a.m., <b>Giorgos Tsiapaliwkas</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">> i don't see how \
it could be? :)
You have right it doesn't. That's my fault.
I just noticed that in the publish dialog that I had enabled the "Enable Signing \
Plasmoid". So when the doPlasmaPkg was called the singing dialog was also \
called.
So the patch is fine. Should I commit it?
P.S.: I still need a shortcut for the install action. What do you want me to put \
there? </pre> </blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">it does't require a \
shortcut; though Ctrl+I seems sane to me...</pre> <br />
<p>- Aaron J.</p>
<br />
<p>On May 24th, 2012, 5:31 p.m., Giorgos Tsiapaliwkas wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for Plasma.</div>
<div>By Giorgos Tsiapaliwkas.</div>
<p style="color: grey;"><i>Updated May 24, 2012, 5:31 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Hello,
I ported Publisher to a ui file and I added an install action as sebas \
proposed.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">When I active the install project action the Publisher::doPublish() is \
called. This mustn't happen.
Also I am don't know which shortcut to choose.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>CMakeLists.txt <span style="color: grey">(7e1bf4b)</span></li>
<li>mainwindow.h <span style="color: grey">(bd4d376)</span></li>
<li>mainwindow.cpp <span style="color: grey">(4728894)</span></li>
<li>plasmateui.rc <span style="color: grey">(9123298)</span></li>
<li>publisher/publisher.h <span style="color: grey">(ee57cf3)</span></li>
<li>publisher/publisher.cpp <span style="color: grey">(11ddf36)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/105031/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic