'Re: Review Request: Blur tooltip backgrounds from system settings.'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    Re: Review Request: Blur tooltip backgrounds from system settings.
From:       "Commit Hook" <null () kde ! org>
Date:       2012-05-26 22:51:51
Message-ID: 20120526225151.2927.79880 () vidsolbach ! de
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105060/#review14198
-----------------------------------------------------------

This review has been submitted with commit 946b6c0790e8b26152dc327e072af2da=
574ddcf8 by Mark Gaiser to branch master.

- Commit Hook

On May 26, 2012, 1:44 p.m., Mark Gaiser wrote:
> =

> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/105060/
> -----------------------------------------------------------
> =

> (Updated May 26, 2012, 1:44 p.m.)
> =

> =

> Review request for Plasma.
> =

> =

> Description
> -------
> =

> Tooltips from system settings are not blurred. This makes them blurred.
> As for the above groups, why isn't there a kde-workspace?
> =

> =

> Diffs
> -----
> =

>   systemsettings/app/CMakeLists.txt c6546bf =

>   systemsettings/app/ToolTips/ktooltipwindow.cpp 133e825 =

>   systemsettings/app/ToolTips/ktooltipwindow_p.h 0813e6a =

> =

> Diff: http://git.reviewboard.kde.org/r/105060/diff/
> =

> =

> Testing
> -------
> =

> Tested it on 4.8. Works and looks nice. I only compile tested it in maste=
r.
> =

> =

> Thanks,
> =

> Mark Gaiser
> =

>

[Attachment #5 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="http://git.reviewboard.kde.org/r/105060/">http://git.reviewboard.kde.org/r/105060/</a>
  </td>
    </tr>
   </table>
   <br />

 <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This review has been \
submitted with commit 946b6c0790e8b26152dc327e072af2da574ddcf8 by Mark Gaiser to \
branch master.</pre>  <br />

<p>- Commit</p>

<br />
<p>On May 26th, 2012, 1:44 p.m., Mark Gaiser wrote:</p>

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;">  <tr>
  <td>

<div>Review request for Plasma.</div>
<div>By Mark Gaiser.</div>

<p style="color: grey;"><i>Updated May 26, 2012, 1:44 p.m.</i></p>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Tooltips from system settings are not blurred. This makes them blurred. \
As for the above groups, why isn&#39;t there a kde-workspace?</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Tested it on 4.8. Works and looks nice. I only compile tested it in \
master.</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>systemsettings/app/CMakeLists.txt <span style="color: \
grey">(c6546bf)</span></li>

 <li>systemsettings/app/ToolTips/ktooltipwindow.cpp <span style="color: \
grey">(133e825)</span></li>

 <li>systemsettings/app/ToolTips/ktooltipwindow_p.h <span style="color: \
grey">(0813e6a)</span></li>

</ul>

<p><a href="http://git.reviewboard.kde.org/r/105060/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[prev in list] [next in list] [prev in thread] [next in thread] 