'Review Request: SortFilterModel: Do not reset model while changing the regexp'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    Review Request: SortFilterModel: Do not reset model while changing the regexp
From:       Aurélien Gâteau <agateau () kde ! org>
Date:       2012-05-25 14:40:36
Message-ID: 20120525144036.28064.10183 () vidsolbach ! de
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105042/
-----------------------------------------------------------

Review request for Plasma.

Description
-------

SortFilterModel::setRegExp() calls beginResetModel() before setting the regexp and \
endResetModel() when done. This cause flickering as the QML view must refresh its \
entire content. QSortFilterProxyModel correctly add or remove rows when filtering, so \
resetting the model is not necessary.

Diffs
-----

  plasma/declarativeimports/core/datamodel.cpp 97d129e 

Diff: http://git.reviewboard.kde.org/r/105042/diff/

Testing
-------

Test script attached demonstrates the problem by having a delegate whose opacity goes \
from 0 to 1 when completed.

- Download regexp-flicker.{pro,cpp,qml}
- run qmake ; make
- Type in the input field => without the patch, remaining items flicker. With the \
patch they do not because they are not recreated.

Thanks,

Aurélien Gâteau

[Attachment #5 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="http://git.reviewboard.kde.org/r/105042/">http://git.reviewboard.kde.org/r/105042/</a>
  </td>
    </tr>
   </table>
   <br />

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;">  <tr>
  <td>

<div>Review request for Plasma.</div>
<div>By Aurélien Gâteau.</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">SortFilterModel::setRegExp() calls beginResetModel() before setting the \
regexp and endResetModel() when done. This cause flickering as the QML view must \
refresh its entire content. QSortFilterProxyModel correctly add or remove rows when \
filtering, so resetting the model is not necessary.</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Test script attached demonstrates the problem by having a delegate whose \
opacity goes from 0 to 1 when completed.

- Download regexp-flicker.{pro,cpp,qml}
- run qmake ; make
- Type in the input field =&gt; without the patch, remaining items flicker. With the \
patch they do not because they are not recreated.</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>plasma/declarativeimports/core/datamodel.cpp <span style="color: \
grey">(97d129e)</span></li>

</ul>

<p><a href="http://git.reviewboard.kde.org/r/105042/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[prev in list] [next in list] [prev in thread] [next in thread] 