[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-panel-devel
Subject: Review Request: Plasmate: request to merge terietor/remoteinstaller to master
From: "Giorgos Tsiapaliwkas" <terietor () gmail ! com>
Date: 2012-05-24 17:49:56
Message-ID: 20120524174956.1494.8258 () vidsolbach ! de
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105032/
-----------------------------------------------------------
Review request for Plasma.
Description
-------
Hello,
in terietor/remoteinstaller I have create a remote installer.
The goal is to install the projects remotely to another computer.
You access the remote install either inside plasmate or using the plasmarem=
oteinstaller binary.
Diffs
-----
CMakeLists.txt 7e1bf4b =
publisher/publisher.h ee57cf3 =
publisher/publisher.cpp 11ddf36 =
publisher/remoteinstaller/remoteinstaller.h PRE-CREATION =
publisher/remoteinstaller/remoteinstaller.cpp PRE-CREATION =
publisher/remoteinstaller/remoteinstaller.ui PRE-CREATION =
publisher/remoteinstaller/remoteinstallerdialog.h PRE-CREATION =
publisher/remoteinstaller/remoteinstallerdialog.cpp PRE-CREATION =
publisher/remoteinstaller/standalone/main.cpp PRE-CREATION =
publisher/remoteinstaller/standalone/plasmaremoteinstaller.h PRE-CREATION =
publisher/remoteinstaller/standalone/plasmaremoteinstaller.cpp PRE-CREATI=
ON =
Diff: http://git.reviewboard.kde.org/r/105032/diff/
Testing
-------
I couldn't find any bugs in the remote installer, but the proccess fails du=
ring KIO::copy.
Apparently I am not writing correct something in the fish protocol.
Right now the remote installer tries to do the above
KIO::copy("/home/terietor/.kde4/share/apps/plasmate/project, "fish://user@i=
p/home/user")
but it fails
Thanks,
Giorgos Tsiapaliwkas
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/105032/">http://git.reviewboard.kde.org/r/105032/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for Plasma.</div>
<div>By Giorgos Tsiapaliwkas.</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Hello,
in terietor/remoteinstaller I have create a remote installer.
The goal is to install the projects remotely to another computer.
You access the remote install either inside plasmate or using the \
plasmaremoteinstaller binary.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">I couldn't find any bugs in the remote installer, but the proccess \
fails during KIO::copy. Apparently I am not writing correct something in the fish \
protocol. Right now the remote installer tries to do the above
KIO::copy("/home/terietor/.kde4/share/apps/plasmate/project, \
"fish://user@ip/home/user")
but it fails
</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>CMakeLists.txt <span style="color: grey">(7e1bf4b)</span></li>
<li>publisher/publisher.h <span style="color: grey">(ee57cf3)</span></li>
<li>publisher/publisher.cpp <span style="color: grey">(11ddf36)</span></li>
<li>publisher/remoteinstaller/remoteinstaller.h <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>publisher/remoteinstaller/remoteinstaller.cpp <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>publisher/remoteinstaller/remoteinstaller.ui <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>publisher/remoteinstaller/remoteinstallerdialog.h <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>publisher/remoteinstaller/remoteinstallerdialog.cpp <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>publisher/remoteinstaller/standalone/main.cpp <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>publisher/remoteinstaller/standalone/plasmaremoteinstaller.h <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>publisher/remoteinstaller/standalone/plasmaremoteinstaller.cpp <span \
style="color: grey">(PRE-CREATION)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/105032/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic