[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-panel-devel
Subject: Re: Review Request: Plasma::RunnerManager: only dequeue our ThreadWeaver jobs
From: Aurélien Gâteau <agateau () kde ! org>
Date: 2012-05-24 9:50:56
Message-ID: 20120524095056.28632.99829 () vidsolbach ! de
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104973/
-----------------------------------------------------------
(Updated May 24, 2012, 9:50 a.m.)
Review request for kdelibs and Plasma.
Changes
-------
Subscribing Plasma as there are probably more people working on this class =
there.
Description
-------
When RunnerManager::reset() is called, all ThreadWeaver jobs are dequeued, =
including jobs from other parts of the code. This patch changes this to onl=
y dequeue the jobs created by this instance of RunnerManager.
Diffs
-----
plasma/runnermanager.cpp 49569a3 =
Diff: http://git.reviewboard.kde.org/r/104973/diff/
Testing
-------
I have more than one RunnerManager working at once in a project. Without th=
e patch, only one manager return results.
Thanks,
Aur=C3=A9lien G=C3=A2teau
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px \
#c9c399 solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/104973/">http://git.reviewboard.kde.org/r/104973/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px \
black solid;"> <tr>
<td>
<div>Review request for kdelibs and Plasma.</div>
<div>By Aurélien Gâteau.</div>
<p style="color: grey;"><i>Updated May 24, 2012, 9:50 a.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: \
1.5em;">Changes</h1> <table width="100%" bgcolor="#ffffff" cellspacing="0" \
cellpadding="10" style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Subscribing Plasma as there are probably more people working \
on this class there.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description \
</h1> <table width="100%" bgcolor="#ffffff" cellspacing="0" \
cellpadding="10" style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">When RunnerManager::reset() is called, all ThreadWeaver jobs \
are dequeued, including jobs from other parts of the code. This patch \
changes this to only dequeue the jobs created by this instance of \
RunnerManager.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing \
</h1> <table width="100%" bgcolor="#ffffff" cellspacing="0" \
cellpadding="10" style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">I have more than one RunnerManager working at once in a \
project. Without the patch, only one manager return results.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> \
</h1> <ul style="margin-left: 3em; padding-left: 0;">
<li>plasma/runnermanager.cpp <span style="color: \
grey">(49569a3)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/104973/diff/" \
style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic