[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-panel-devel
Subject: Re: Review Request: qml port of showActivityManager (it's just an icon)
From: "Commit Hook" <null () kde ! org>
Date: 2012-05-24 9:41:08
Message-ID: 20120524094108.28266.43689 () vidsolbach ! de
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104959/#review14116
-----------------------------------------------------------
This review has been submitted with commit 51924c2f35063e0b0cc9446224c22465=
bd72d4f9 by Gregor T=C3=A4tzner to branch master.
- Commit Hook
On May 21, 2012, 6:46 p.m., Greg T wrote:
> =
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/104959/
> -----------------------------------------------------------
> =
> (Updated May 21, 2012, 6:46 p.m.)
> =
> =
> Review request for Plasma.
> =
> =
> Description
> -------
> =
> Hello, I've played around a bit with the new qml stuff. Basically this po=
rt works the same way as the c++ version. Though the icon doesn't glow on m=
ouse hover. How can I fix that?
> =
> =
> Diffs
> -----
> =
> plasma/desktop/applets/CMakeLists.txt 731c70c =
> plasma/desktop/applets/showActivityManager/CMakeLists.txt 592f38f =
> plasma/desktop/applets/showActivityManager/Messages.sh 0f07ff5 =
> plasma/desktop/applets/showActivityManager/package/contents/ui/main.qml=
PRE-CREATION =
> plasma/desktop/applets/showActivityManager/package/metadata.desktop PRE=
-CREATION =
> plasma/desktop/applets/showActivityManager/plasma-applet-org.kde.showAc=
tivityManager.desktop 98e9bd6 =
> plasma/desktop/applets/showActivityManager/showActivityManager.h f58fbb=
7 =
> plasma/desktop/applets/showActivityManager/showActivityManager.cpp e77d=
f0d =
> plasma/generic/dataengines/activities/activities.operations f9ce034 =
> plasma/generic/dataengines/activities/activityjob.cpp 7fe8823 =
> =
> Diff: http://git.reviewboard.kde.org/r/104959/diff/
> =
> =
> Testing
> -------
> =
> click: activity manager comes up
> click again: manager vanishes!
> =
> =
> Thanks,
> =
> Greg T
> =
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/104959/">http://git.reviewboard.kde.org/r/104959/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This review has been \
submitted with commit 51924c2f35063e0b0cc9446224c22465bd72d4f9 by Gregor Tätzner to \
branch master.</pre> <br />
<p>- Commit</p>
<br />
<p>On May 21st, 2012, 6:46 p.m., Greg T wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for Plasma.</div>
<div>By Greg T.</div>
<p style="color: grey;"><i>Updated May 21, 2012, 6:46 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Hello, I've played around a bit with the new qml stuff. Basically \
this port works the same way as the c++ version. Though the icon doesn't glow on \
mouse hover. How can I fix that?</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">click: activity manager comes up click again: manager vanishes!</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>plasma/desktop/applets/CMakeLists.txt <span style="color: \
grey">(731c70c)</span></li>
<li>plasma/desktop/applets/showActivityManager/CMakeLists.txt <span style="color: \
grey">(592f38f)</span></li>
<li>plasma/desktop/applets/showActivityManager/Messages.sh <span style="color: \
grey">(0f07ff5)</span></li>
<li>plasma/desktop/applets/showActivityManager/package/contents/ui/main.qml <span \
style="color: grey">(PRE-CREATION)</span></li>
<li>plasma/desktop/applets/showActivityManager/package/metadata.desktop <span \
style="color: grey">(PRE-CREATION)</span></li>
<li>plasma/desktop/applets/showActivityManager/plasma-applet-org.kde.showActivityManager.desktop \
<span style="color: grey">(98e9bd6)</span></li>
<li>plasma/desktop/applets/showActivityManager/showActivityManager.h <span \
style="color: grey">(f58fbb7)</span></li>
<li>plasma/desktop/applets/showActivityManager/showActivityManager.cpp <span \
style="color: grey">(e77df0d)</span></li>
<li>plasma/generic/dataengines/activities/activities.operations <span style="color: \
grey">(f9ce034)</span></li>
<li>plasma/generic/dataengines/activities/activityjob.cpp <span style="color: \
grey">(7fe8823)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/104959/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic