[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-panel-devel
Subject: Re: Review Request: Plasmate: fix publisher's combobox and doCMake slot
From: Sebastian_Kügler <sebas () kde ! org>
Date: 2012-05-23 21:24:25
Message-ID: 20120523212425.13384.22913 () vidsolbach ! de
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
> On May 22, 2012, 12:49 p.m., Aaron J. Seigo wrote:
> > publisher/publisher.cpp, line 132
> > <http://git.reviewboard.kde.org/r/104969/diff/1/?file=64637#file64637line132>
> >
> > looks like a stray change... (though signign could be fixed to signing ;)
>
> Giorgos Tsiapaliwkas wrote:
> signing doesn't work? I have to investigate it. I should open another review. Yes?
Aaron was refering to a typo in that comment "signign" vs. "signing". That's all.
> On May 22, 2012, 12:49 p.m., Aaron J. Seigo wrote:
> > publisher/publisher.cpp, line 185
> > <http://git.reviewboard.kde.org/r/104969/diff/1/?file=64637#file64637line185>
> >
> > QDir has a cd(const QString &) method that is what you are looking for
>
> Giorgos Tsiapaliwkas wrote:
> I played with QDir::cd but it wasn't working. KProcess wasn't aware of the QDir::cd \
> so I used, KProcess::setWorkingDirectory. In my patch I don't like the fact that I \
> use qgetenv it should be replaced with something else.Do you agree?
>
> Also the cmake install works correctly now
Seems good enough, let's get this patch in and move on to other things :)
- Sebastian
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104969/#review14046
-----------------------------------------------------------
On May 23, 2012, 6:25 p.m., Giorgos Tsiapaliwkas wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/104969/
> -----------------------------------------------------------
>
> (Updated May 23, 2012, 6:25 p.m.)
>
>
> Review request for Plasma.
>
>
> Description
> -------
>
> Hello,
>
> those are some issues which plasmate's publisher has
>
> problem 1: the publisher's combobox wasn't aware for the right slot. When \
> currentIndex was emitted both slots(doPlasmaPkg and doCMake was called.) I fixed \
> that. problem 2: publisher's cmake process was trying to install a \
> projectName.plasmoid file and not projectPath/CMakeLists.txt. I fixed that. problem \
> 3: when the cmake slot is called, cmake creates the known temporary files in \
> directory like ~/.kde4/share/apps/plasmate/projectName. I haven't fixed that. How \
> can I change the current directory with Qt?
>
> Diffs
> -----
>
> publisher/publisher.h 6eba693
> publisher/publisher.cpp 3fcd268
> templates/cmakelists c3e2ce9
>
> Diff: http://git.reviewboard.kde.org/r/104969/diff/
>
>
> Testing
> -------
>
> WIP
>
>
> Thanks,
>
> Giorgos Tsiapaliwkas
>
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/104969/">http://git.reviewboard.kde.org/r/104969/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <p style="margin-top: 0;">On May 22nd, 2012, 12:49 p.m., <b>Aaron J. \
Seigo</b> wrote:</p> <blockquote style="margin-left: 1em; border-left: 2px solid \
#d0d0d0; padding-left: 10px;">
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="http://git.reviewboard.kde.org/r/104969/diff/1/?file=64637#file64637line132" \
style="color: black; font-weight: bold; text-decoration: \
underline;">publisher/publisher.cpp</a> <span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">void \
Publisher::doExport()</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2">129</font></th> <td bgcolor="#fdfebc" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="c1">// If \
signign is enabled, lets do that!</span></pre></td> <th bgcolor="#e9eaa8" \
style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" \
align="right"><font size="2">132</font></th> <td bgcolor="#fdfebc" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="c1">// If \
signign is enabled, lets do that!<span class="hl">1</span></span></pre></td> </tr>
</tbody>
</table>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">looks like a stray \
change... (though signign could be fixed to signing ;)</pre> </blockquote>
<p>On May 23rd, 2012, 6:23 p.m., <b>Giorgos Tsiapaliwkas</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">signing doesn't \
work? I have to investigate it. I should open another review. Yes?</pre> \
</blockquote>
</blockquote>
<pre style="margin-left: 1em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Aaron was \
refering to a typo in that comment "signign" vs. "signing". \
That's all.</pre> <br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <p style="margin-top: 0;">On May 22nd, 2012, 12:49 p.m., <b>Aaron J. \
Seigo</b> wrote:</p> <blockquote style="margin-left: 1em; border-left: 2px solid \
#d0d0d0; padding-left: 10px;">
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="http://git.reviewboard.kde.org/r/104969/diff/1/?file=64637#file64637line185" \
style="color: black; font-weight: bold; text-decoration: \
underline;">publisher/publisher.cpp</a> <span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="2"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">void \
Publisher::doCMake()</pre></td> <td colspan="2"><pre style="font-size: 8pt; \
line-height: 140%; margin: 0; ">void Publisher::doCMake(int index)</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th> <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">184</font></th> <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span \
class="c1">//</span><span class="cs">TODO</span><span class="c1"> now we have to move \
into the build dir but how?</span></pre></td> </tr>
</tbody>
</table>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">QDir has a cd(const \
QString &) method that is what you are looking for</pre> </blockquote>
<p>On May 23rd, 2012, 6:23 p.m., <b>Giorgos Tsiapaliwkas</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I played with QDir::cd \
but it wasn't working. KProcess wasn't aware of the QDir::cd so I used, \
KProcess::setWorkingDirectory. In my patch I don't like the fact that I use \
qgetenv it should be replaced with something else.Do you agree?
Also the cmake install works correctly now</pre>
</blockquote>
</blockquote>
<pre style="margin-left: 1em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Seems good \
enough, let's get this patch in and move on to other things :)</pre> <br />
<p>- Sebastian</p>
<br />
<p>On May 23rd, 2012, 6:25 p.m., Giorgos Tsiapaliwkas wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for Plasma.</div>
<div>By Giorgos Tsiapaliwkas.</div>
<p style="color: grey;"><i>Updated May 23, 2012, 6:25 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Hello,
those are some issues which plasmate's publisher has
problem 1: the publisher's combobox wasn't aware for the right slot. When \
currentIndex was emitted both slots(doPlasmaPkg and doCMake was called.) I fixed \
that. problem 2: publisher's cmake process was trying to install a \
projectName.plasmoid file and not projectPath/CMakeLists.txt. I fixed that. problem \
3: when the cmake slot is called, cmake creates the known temporary files in \
directory like ~/.kde4/share/apps/plasmate/projectName. I haven't fixed that. How \
can I change the current directory with Qt?</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">WIP </pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>publisher/publisher.h <span style="color: grey">(6eba693)</span></li>
<li>publisher/publisher.cpp <span style="color: grey">(3fcd268)</span></li>
<li>templates/cmakelists <span style="color: grey">(c3e2ce9)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/104969/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic