[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    Re: Review Request: QML Lock/logout applet
From:       Viranch Mehta <viranch.mehta () gmail ! com>
Date:       2012-05-02 0:17:08
Message-ID: CADk4Opb8RfP79Gz4d8S9DWG0K=MB-4FLLPoSgUbGKOuNhkyCSA () mail ! gmail ! com
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]


On Wed, May 2, 2012 at 5:19 AM, Viranch Mehta <viranch.mehta@gmail.com>wrote:

> On Tue, May 1, 2012 at 6:25 PM, Marco Martin <notmart@gmail.com> wrote:
>
>> it should be merged asap because freeze is on 3rd. can you do it either
>> today,
>> or i can do it as well?
>>
>
> I just added confirmation dialog for sleep as well, and now i'm merging
> the branch.
>

Okay I just merged the branch plasma/viranch/powermanagement containing the
battery and lock/logout QML applets to master. Marco could you please
review it
to check if the merge was correct. Also, should I delete the branch now? If
yes,
git -d plasma/viranch/powermanagement && git push will do it, right?


>
> Cheers,
> Viranch
>
>

[Attachment #5 (text/html)]

<div class="gmail_extra"><div class="gmail_quote">On Wed, May 2, 2012 at 5:19 AM, \
Viranch Mehta <span dir="ltr">&lt;<a href="mailto:viranch.mehta@gmail.com" \
target="_blank">viranch.mehta@gmail.com</a>&gt;</span> wrote:<br> <blockquote \
class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc \
solid;padding-left:1ex"><div class="gmail_extra"><div class="gmail_quote"><div \
class="im">On Tue, May 1, 2012 at 6:25 PM, Marco Martin <span dir="ltr">&lt;<a \
href="mailto:notmart@gmail.com" target="_blank">notmart@gmail.com</a>&gt;</span> \
wrote:<br> <blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px \
#ccc solid;padding-left:1ex"> <div><div>it should be merged asap because freeze is on \
3rd. can you do it either today,</div></div> or i can do it as \
well?<br></blockquote><div><br></div></div><div class="im"><div>I just added \
confirmation dialog for sleep as well, and now i&#39;m merging the \
branch.</div></div></div></div></blockquote><div><br></div> <div>Okay I just merged \
the branch plasma/viranch/powermanagement containing the</div><div>battery and \
lock/logout QML applets to master. Marco could you please review it</div><div>to \
check if the merge was correct. Also, should I delete the branch now? If yes,</div> \
<div>git -d plasma/viranch/powermanagement &amp;&amp; git push will do it, \
right?</div><div> </div><blockquote class="gmail_quote" style="margin:0 0 0 \
.8ex;border-left:1px #ccc solid;padding-left:1ex"><div class="gmail_extra"> <div \
class="gmail_quote"><div \
class="im"><div><br></div><div>Cheers,</div><div>Viranch</div><div><br></div></div></div>
 </div>
</blockquote></div><br></div>



_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel


[prev in list] [next in list] [prev in thread] [next in thread]