'Re: Review Request: Displaying playing media time in correct format'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    Re: Review Request: Displaying playing media time in correct format
From:       "Sinny Kumari" <ksinny () gmail ! com>
Date:       2012-05-01 14:22:11
Message-ID: 20120501142211.3053.92934 () vidsolbach ! de
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]

> On May 1, 2012, 2:20 p.m., Sinny Kumari wrote:
> > Ship It!

Looks fine to me. Go ahead if you have push access else I will do it :)

- Sinny

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104762/#review13202
-----------------------------------------------------------

On May 1, 2012, 7:32 a.m., nancy kumari wrote:
> =

> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/104762/
> -----------------------------------------------------------
> =

> (Updated May 1, 2012, 7:32 a.m.)
> =

> =

> Review request for Plasma.
> =

> =

> Description
> -------
> =

> Displaying playing media time in correct format. previously when value of=
 hour, minute or second was less than 10, then it was displaying in single =
digit format(0:13:5). Now it displays in proper format(00:13:05).
> =

> =

> Diffs
> -----
> =

>   shells/newshell/package/contents/ui/mediacenter.qml 71c9baa =

> =

> Diff: http://git.reviewboard.kde.org/r/104762/diff/
> =

> =

> Testing
> -------
> =

> Working fine.
> =

> =

> Thanks,
> =

> nancy kumari
> =

>

[Attachment #5 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="http://git.reviewboard.kde.org/r/104762/">http://git.reviewboard.kde.org/r/104762/</a>
  </td>
    </tr>
   </table>
   <br />

<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;">  <p style="margin-top: 0;">On May 1st, 2012, 2:20 p.m., <b>Sinny Kumari</b> \
wrote:</p>  <blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; \
padding-left: 10px;">  <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Ship \
It!</pre>  </blockquote>

</blockquote>

<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Looks fine to me. Go \
ahead if you have push access else I will do it :)</pre> <br />

<p>- Sinny</p>

<br />
<p>On May 1st, 2012, 7:32 a.m., nancy kumari wrote:</p>

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;">  <tr>
  <td>

<div>Review request for Plasma.</div>
<div>By nancy kumari.</div>

<p style="color: grey;"><i>Updated May 1, 2012, 7:32 a.m.</i></p>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Displaying playing media time in correct format. previously when value \
of hour, minute or second was less than 10, then it was displaying in single digit \
format(0:13:5). Now it displays in proper format(00:13:05).</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Working fine.</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>shells/newshell/package/contents/ui/mediacenter.qml <span style="color: \
grey">(71c9baa)</span></li>

</ul>

<p><a href="http://git.reviewboard.kde.org/r/104762/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[prev in list] [next in list] [prev in thread] [next in thread] 