From kde-panel-devel Mon Apr 30 19:52:45 2012 From: =?utf-8?q?Martin_Gr=C3=A4=C3=9Flin?= Date: Mon, 30 Apr 2012 19:52:45 +0000 To: kde-panel-devel Subject: Re: Review Request: "New Desktop" in To Desktop menu Message-Id: <20120430195245.10568.78692 () vidsolbach ! de> X-MARC-Message: https://marc.info/?l=kde-panel-devel&m=133581570806439 MIME-Version: 1 Content-Type: multipart/mixed; boundary="--===============8637773269493563190==" --===============8637773269493563190== Content-Type: multipart/alternative; boundary="===============4676337997019185810==" --===============4676337997019185810== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable > On April 29, 2012, 8:08 p.m., Martin Gr=C3=A4=C3=9Flin wrote: > > kwin/useractions.cpp, line 505 > > > > > > In KWin code please use the constant value - that's what it's fore = :-) > > = > > I would also suggest to write it as: > > if (numberOfDesktops() >=3D KWIN_MAX_NUMBER_DESKTOPS) > = > makis marimpis wrote: > yeah, i skipped it because i'm getting an error that KWIN_MAX_NUMBER_= DESKTOPS is undeclared at this scope :/ it's defined in workspace.cpp so no surprise that you cannot compile with i= t. If you want you could add a getter to Workspace to get this value. - Martin ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104781/#review13111 ----------------------------------------------------------- On April 29, 2012, 8:22 p.m., makis marimpis wrote: > = > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/104781/ > ----------------------------------------------------------- > = > (Updated April 29, 2012, 8:22 p.m.) > = > = > Review request for kwin and Plasma. > = > = > Description > ------- > = > I found http://community.kde.org/KWin/Ideas#.22New_Desktop.22_in_To_Deskt= op_menu and i thought i would be nice to have. > Only a few lines of code. > = > = > Diffs > ----- > = > kwin/useractions.cpp 09e18c3d061f6521749ebfe2665e2db9099dad9f = > libs/taskmanager/taskactions.cpp 7917c0d12511937e2ce0092720a82c1e99fcd6= bd = > libs/taskmanager/taskactions_p.h 52eae0513e62c7dbb3066fc26cd290bada7d14= 79 = > = > Diff: http://git.reviewboard.kde.org/r/104781/diff/ > = > = > Testing > ------- > = > Moved client to "New Desktop". Seems to work fine. > = > = > Thanks, > = > makis marimpis > = > --===============4676337997019185810== Content-Type: text/html; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable

This is an automatically generated e-mail. To reply, visit: http://git.revie= wboard.kde.org/r/104781/

On April 29th, 2012, 8:08 p.m., Martin Gr= =C3=A4=C3=9Flin wrote:

= = =

kwin/useractions.cpp (Diff revision 2)
void Workspace::desktopPopupAboutToShow()
		505	if (numberOfDesktops() + 1 > 20) //KWIN_MAX_NUMBER_DESKTOPS

In KWin c=
ode please use the constant value - that's what it's fore :-)

I would also suggest to write it as:
if (numberOfDesktops() >=3D KWIN_MAX_NUMBER_DESKTOPS)

On April 29th, 2012, 8:37 p.m., makis marimpis wrote:

yeah, i s=
kipped it because i'm getting an error that KWIN_MAX_NUMBER_DESKTOPS is=
 undeclared at this scope :/

it's defined in workspace.cpp so no surprise that you cannot com=
pile with it.

If you want you could add a getter to Workspace to get this value.

- Martin

On April 29th, 2012, 8:22 p.m., makis marimpis wrote:

Review request for kwin and Plasma.

By makis marimpis.

Updated April 29, 2012, 8:22 p.m.

Descripti= on

I found http://community.kde.org/KWin/Ideas#.22New_Desktop.2=
2_in_To_Desktop_menu and i thought i would be nice to have.
Only a few lines of code.

Testing <= /h1>

Moved client to "New Desktop". Seems to work fine.=

Diffs=

kwin/useractions.cpp (09e18c3d061f6521749e= bfe2665e2db9099dad9f)
libs/taskmanager/taskactions.cpp (7917c0d1= 2511937e2ce0092720a82c1e99fcd6bd)
libs/taskmanager/taskactions_p.h (52eae051= 3e62c7dbb3066fc26cd290bada7d1479)

--===============4676337997019185810==-- --===============8637773269493563190== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel --===============8637773269493563190==--