'Re: Review Request: "New Desktop" in To Desktop menu'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    Re: Review Request: "New Desktop" in To Desktop menu
From:       "makis marimpis" <makhsm () gmail ! com>
Date:       2012-04-29 20:22:57
Message-ID: 20120429202257.13724.90924 () vidsolbach ! de
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104781/
-----------------------------------------------------------

(Updated April 29, 2012, 8:22 p.m.)

Review request for kwin and Plasma.

Changes
-------

Added plasma to groups.
Feedback is needed for the usage of QX11Info.

Description
-------

I found http://community.kde.org/KWin/Ideas#.22New_Desktop.22_in_To_Desktop=
_menu and i thought i would be nice to have.
Only a few lines of code.

Diffs
-----

  kwin/useractions.cpp 09e18c3d061f6521749ebfe2665e2db9099dad9f =

  libs/taskmanager/taskactions.cpp 7917c0d12511937e2ce0092720a82c1e99fcd6bd =

  libs/taskmanager/taskactions_p.h 52eae0513e62c7dbb3066fc26cd290bada7d1479 =

Diff: http://git.reviewboard.kde.org/r/104781/diff/

Testing
-------

Moved client to "New Desktop". Seems to work fine.

Thanks,

makis marimpis

[Attachment #5 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="http://git.reviewboard.kde.org/r/104781/">http://git.reviewboard.kde.org/r/104781/</a>
  </td>
    </tr>
   </table>
   <br />

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;">  <tr>
  <td>

<div>Review request for kwin and Plasma.</div>
<div>By makis marimpis.</div>

<p style="color: grey;"><i>Updated April 29, 2012, 8:22 p.m.</i></p>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Changes</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Added plasma to groups. Feedback is needed for the usage of \
QX11Info.</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">I found \
http://community.kde.org/KWin/Ideas#.22New_Desktop.22_in_To_Desktop_menu and i \
thought i would be nice to have. Only a few lines of code.</pre>
  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Moved client to &quot;New Desktop&quot;. Seems to work fine.</pre>  \
</td>  </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>kwin/useractions.cpp <span style="color: \
grey">(09e18c3d061f6521749ebfe2665e2db9099dad9f)</span></li>

 <li>libs/taskmanager/taskactions.cpp <span style="color: \
grey">(7917c0d12511937e2ce0092720a82c1e99fcd6bd)</span></li>

 <li>libs/taskmanager/taskactions_p.h <span style="color: \
grey">(52eae0513e62c7dbb3066fc26cd290bada7d1479)</span></li>

</ul>

<p><a href="http://git.reviewboard.kde.org/r/104781/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[prev in list] [next in list] [prev in thread] [next in thread] 