--===============1629095646990273487== Content-Type: multipart/alternative; boundary="===============4314441365329075477==" --===============4314441365329075477== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104735/#review12929 ----------------------------------------------------------- This review has been submitted with commit ecf7d5090c7e2abbe82e91ef11833885= b1763041 by Aur=C3=A9lien G=C3=A2teau to branch master. - Commit Hook On April 26, 2012, 8:27 a.m., Aur=C3=A9lien G=C3=A2teau wrote: > = > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/104735/ > ----------------------------------------------------------- > = > (Updated April 26, 2012, 8:27 a.m.) > = > = > Review request for Plasma and David Edmundson. > = > = > Description > ------- > = > This patch fixes two issues in ToolButton layout: > = > 1. Make sure there is some space between the button icon and its text > = > 2. Do not enforce a minimum width > = > The reason for #2 is that having a minimum width does not make much sense= for a ToolButton: > - It should aim at using the minimum amount of horizontal space when used= in a ToolBar. > - It looks unbalanced when used with an icon because the content is flush= ed to the left, leaving a large amount of white-space on the right. (See at= tached screenshots) > = > = > Diffs > ----- > = > plasma/declarativeimports/plasmacomponents/qml/ToolButton.qml 0447a69 = > = > Diff: http://git.reviewboard.kde.org/r/104735/diff/ > = > = > Testing > ------- > = > Run attached test script, you should notice the differences in spacing be= tween button icon and text, as well as in the white-space on the right of t= he button. > = > = > Screenshots > ----------- > = > Before > http://git.reviewboard.kde.org/r/104735/s/545/ > After > http://git.reviewboard.kde.org/r/104735/s/546/ > = > = > Thanks, > = > Aur=C3=A9lien G=C3=A2teau > = > --===============4314441365329075477== Content-Type: text/html; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable
This is an automatically generated e-mail. To reply, visit: http://git.revie= wboard.kde.org/r/104735/ 

This revie=
w has been submitted with commit ecf7d5090c7e2abbe82e91ef11833885b1763041 b=
y Aur=C3=A9lien G=C3=A2teau to branch master.

- Commit


On April 26th, 2012, 8:27 a.m., Aur=C3=A9lien G=C3=A2teau wrote:

Review request for Plasma and David Edmundson.
By Aur=C3=A9lien G=C3=A2teau.

Updated April 26, 2012, 8:27 a.m.

Descripti= on 

This patch fixes two issues in ToolButton layout:

1. Make sure there is some space between the button icon and its text

2. Do not enforce a minimum width

The reason for #2 is that having a minimum width does not make much sense f=
or a ToolButton:
- It should aim at using the minimum amount of horizontal space when used i=
n a ToolBar.
- It looks unbalanced when used with an icon because the content is flushed=
 to the left, leaving a large amount of white-space on the right. (See atta=
ched screenshots)

Testing <= /h1> 
Run attached test script, you should notice the differences =
in spacing between button icon and text, as well as in the white-space on t=
he right of the button.

Diffs=

  • plasma/declarativeimports/plasmacomponents/qml/ToolButton.qml (0447a69)

View Diff

Screensho= ts

--===============4314441365329075477==-- --===============1629095646990273487== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel --===============1629095646990273487==--