|
Review request for Plasma and David Edmundson.
By Aurélien Gâteau.
Updated April 26, 2012, 8:27 a.m.
Description
This patch fixes two issues in ToolButton layout:
1. Make sure there is some space between the button icon and its text
2. Do not enforce a minimum width
The reason for #2 is that having a minimum width does not make much sense for a ToolButton:
- It should aim at using the minimum amount of horizontal space when used in a ToolBar.
- It looks unbalanced when used with an icon because the content is flushed to the left, leaving a large amount of white-space on the right. (See attached screenshots)
|
Testing
Run attached test script, you should notice the differences in spacing between button icon and text, as well as in the white-space on the right of the button.
|
Diffs
- plasma/declarativeimports/plasmacomponents/qml/ToolButton.qml (0447a69)
View Diff
Screenshots
|
