--===============8491982897230634769== Content-Type: multipart/alternative; boundary="===============3297615607910374101==" --===============3297615607910374101== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104727/#review12921 ----------------------------------------------------------- This review has been submitted with commit b10e79a8db422e2d5a1f65149333e4f9= f29f10dc by Aur=C3=A9lien G=C3=A2teau to branch master. - Commit Hook On April 25, 2012, 4:32 p.m., Aur=C3=A9lien G=C3=A2teau wrote: > = > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/104727/ > ----------------------------------------------------------- > = > (Updated April 25, 2012, 4:32 p.m.) > = > = > Review request for Plasma and David Edmundson. > = > = > Description > ------- > = > ToolButton does not support keyboard navigation. The attached patch fixes= this by: > = > - Using the "surface" item to indicate focus when the "flat" property is = set to true > = > - Not giving focus on click if keyboard navigation is not defined. This i= s a bit tricky, but I figured it would be odd to have a focus border around= a button which is part of a toolbar. I could not think of a better way to = figure out whether giving focus on click made sense or not. > = > = > Diffs > ----- > = > plasma/declarativeimports/plasmacomponents/qml/ToolButton.qml 9e7e715 = > = > Diff: http://git.reviewboard.kde.org/r/104727/diff/ > = > = > Testing > ------- > = > Running attached test script without the patch, "Focusable Button 1" star= ts focused (this can be seen by pressing "space") but there is no indicatio= n that it is. With the patch, an hover frame appears around the focused but= ton. Pressing tab moves the focus to "Focusable Button 2" which gets the ho= ver frame. > Clicking one of the focusable buttons gives them focus as well, but click= ing one of the toolbar buttons does not, since keyboard navigation is not d= efined for them. > = > = > Thanks, > = > Aur=C3=A9lien G=C3=A2teau > = > --===============3297615607910374101== Content-Type: text/html; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable

This is an automatically generated e-mail. To reply, visit: http://git.revie= wboard.kde.org/r/104727/

This revie=
w has been submitted with commit b10e79a8db422e2d5a1f65149333e4f9f29f10dc b=
y Aur=C3=A9lien G=C3=A2teau to branch master.

- Commit

On April 25th, 2012, 4:32 p.m., Aur=C3=A9lien G=C3=A2teau wrote:

Review request for Plasma and David Edmundson.

By Aur=C3=A9lien G=C3=A2teau.

Updated April 25, 2012, 4:32 p.m.

Descripti= on

ToolButton does not support keyboard navigation. The attache=
d patch fixes this by:

- Using the "surface" item to indicate focus when the "flat&=
quot; property is set to true

- Not giving focus on click if keyboard navigation is not defined. This is =
a bit tricky, but I figured it would be odd to have a focus border around a=
 button which is part of a toolbar. I could not think of a better way to fi=
gure out whether giving focus on click made sense or not.

Testing <= /h1>

Running attached test script without the patch, "Focusa=
ble Button 1" starts focused (this can be seen by pressing "space=
") but there is no indication that it is. With the patch, an hover fra=
me appears around the focused button. Pressing tab moves the focus to "=
;Focusable Button 2" which gets the hover frame.
Clicking one of the focusable buttons gives them focus as well, but clickin=
g one of the toolbar buttons does not, since keyboard navigation is not def=
ined for them.

Diffs=

plasma/declarativeimports/plasmacomponents/qml/ToolButton.qml (9e7e715)

--===============3297615607910374101==-- --===============8491982897230634769== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel --===============8491982897230634769==--