[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    Re: Review Request: Password character support in PlasmaComponents.TextField
From:       "Commit Hook" <null () kde ! org>
Date:       2012-04-26 7:21:15
Message-ID: 20120426072115.3632.87830 () vidsolbach ! de
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104726/#review12920
-----------------------------------------------------------


This review has been submitted with commit 02106d3d4cbaf3434b231cac6cfe444b=
cc26a688 by Aur=C3=A9lien G=C3=A2teau to branch master.

- Commit Hook


On April 25, 2012, 4:10 p.m., Aur=C3=A9lien G=C3=A2teau wrote:
> =

> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/104726/
> -----------------------------------------------------------
> =

> (Updated April 25, 2012, 4:10 p.m.)
> =

> =

> Review request for Plasma and David Edmundson.
> =

> =

> Description
> -------
> =

> TextField password character defaults to the old '*' character. Attached =
patch sets it to unicode bullet, which is more common nowadays and also exp=
ose the property to the outside world (though I am not sure this is really =
needed, tell me if you'd rather drop it).
> =

> =

> Diffs
> -----
> =

>   plasma/declarativeimports/plasmacomponents/qml/TextField.qml 10c4cee =

> =

> Diff: http://git.reviewboard.kde.org/r/104726/diff/
> =

> =

> Testing
> -------
> =

> =

> Thanks,
> =

> Aur=C3=A9lien G=C3=A2teau
> =

>


[Attachment #5 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="http://git.reviewboard.kde.org/r/104726/">http://git.reviewboard.kde.org/r/104726/</a>
  </td>
    </tr>
   </table>
   <br />





 <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This review has been \
submitted with commit 02106d3d4cbaf3434b231cac6cfe444bcc26a688 by Aurélien Gâteau \
to branch master.</pre>  <br />







<p>- Commit</p>


<br />
<p>On April 25th, 2012, 4:10 p.m., Aurélien Gâteau wrote:</p>






<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;">  <tr>
  <td>

<div>Review request for Plasma and David Edmundson.</div>
<div>By Aurélien Gâteau.</div>


<p style="color: grey;"><i>Updated April 25, 2012, 4:10 p.m.</i></p>






<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">TextField password character defaults to the old &#39;*&#39; character. \
Attached patch sets it to unicode bullet, which is more common nowadays and also \
expose the property to the outside world (though I am not sure this is really needed, \
tell me if you&#39;d rather drop it).</pre>  </td>
 </tr>
</table>





<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>plasma/declarativeimports/plasmacomponents/qml/TextField.qml <span style="color: \
grey">(10c4cee)</span></li>

</ul>

<p><a href="http://git.reviewboard.kde.org/r/104726/diff/" style="margin-left: \
3em;">View Diff</a></p>




  </td>
 </tr>
</table>








  </div>
 </body>
</html>



_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel


[prev in list] [next in list] [prev in thread] [next in thread] 

Configure | About | News | Add a list | Sponsored by KoreLogic