[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-panel-devel
Subject: Review Request: Merge the branch KLocaleQMLBindings into master
From: "Giorgos Tsiapaliwkas" <terietor () gmail ! com>
Date: 2012-04-24 20:36:22
Message-ID: 20120424203622.5528.16400 () vidsolbach ! de
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104716/
-----------------------------------------------------------
Review request for Plasma.
Description
-------
Hello,
this branch contains QML bindings for KLocale. I believe that is the time t=
o review it here.
Diffs
-----
plasma/declarativeimports/locale/CMakeLists.txt PRE-CREATION =
plasma/declarativeimports/locale/calendarsystem.h PRE-CREATION =
plasma/declarativeimports/locale/calendarsystem.cpp PRE-CREATION =
plasma/declarativeimports/locale/locale.h PRE-CREATION =
plasma/declarativeimports/locale/locale.cpp PRE-CREATION =
plasma/declarativeimports/locale/localebindingsplugin.h PRE-CREATION =
plasma/declarativeimports/locale/localebindingsplugin.cpp PRE-CREATION =
plasma/declarativeimports/locale/qmldir PRE-CREATION =
plasma/declarativeimports/locale/tests/contents/code/klocaleqmltest.qml P=
RE-CREATION =
plasma/declarativeimports/locale/tests/metadata.desktop PRE-CREATION =
Diff: http://git.reviewboard.kde.org/r/104716/diff/
Testing
-------
there is a plasmoid in kde-runtime/plasma/declarativeimports/locale/tests i=
n which I have exported every property/q_invokable.
Some issues that I will like to mention
a. there is tests/contents/code/klocaleqmltest.qml I believe that it should=
be tests/contents/ui/main.qml
b. the test plasmoid is exported as org.kde.klocaleqmltest it should be org=
.kde.example.localetest
c. Locale::setActiveCatalog and Locale::setMainCatalog since we didn't want=
the bindings to influence the core functionality.
what do you think?
Thanks,
Giorgos Tsiapaliwkas
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/104716/">http://git.reviewboard.kde.org/r/104716/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for Plasma.</div>
<div>By Giorgos Tsiapaliwkas.</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Hello,
this branch contains QML bindings for KLocale. I believe that is the time to review \
it here.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">there is a plasmoid in \
kde-runtime/plasma/declarativeimports/locale/tests in which I have exported every \
property/q_invokable.
Some issues that I will like to mention
a. there is tests/contents/code/klocaleqmltest.qml I believe that it should be \
tests/contents/ui/main.qml b. the test plasmoid is exported as org.kde.klocaleqmltest \
it should be org.kde.example.localetest c. Locale::setActiveCatalog and \
Locale::setMainCatalog since we didn't want the bindings to influence the core \
functionality.
what do you think?</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>plasma/declarativeimports/locale/CMakeLists.txt <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>plasma/declarativeimports/locale/calendarsystem.h <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>plasma/declarativeimports/locale/calendarsystem.cpp <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>plasma/declarativeimports/locale/locale.h <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>plasma/declarativeimports/locale/locale.cpp <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>plasma/declarativeimports/locale/localebindingsplugin.h <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>plasma/declarativeimports/locale/localebindingsplugin.cpp <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>plasma/declarativeimports/locale/qmldir <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>plasma/declarativeimports/locale/tests/contents/code/klocaleqmltest.qml <span \
style="color: grey">(PRE-CREATION)</span></li>
<li>plasma/declarativeimports/locale/tests/metadata.desktop <span style="color: \
grey">(PRE-CREATION)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/104716/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic