[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-panel-devel
Subject: Re: Review Request: icon plasmoid - http url naming
From: "Commit Hook" <null () kde ! org>
Date: 2012-04-20 20:21:58
Message-ID: 20120420202158.13971.52400 () vidsolbach ! de
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/103435/#review12735
-----------------------------------------------------------
This review has been submitted with commit 246d9bcc81878977d68c3cc030f1b6fd2e28cb87 \
by Gregor Tätzner to branch KDE/4.8.
- Commit Hook
On Jan. 10, 2012, 1:41 p.m., Greg T wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/103435/
> -----------------------------------------------------------
>
> (Updated Jan. 10, 2012, 1:41 p.m.)
>
>
> Review request for Plasma.
>
>
> Description
> -------
>
> I added a special case so the desktop icon gets a pretty name when you drag and \
> drop a link onto your desktop. Additional, a regex strips out the protocol (like in \
> firefox)
> I'm allowed to commit it?
>
>
> This addresses bug 199811.
> http://bugs.kde.org/show_bug.cgi?id=199811
>
>
> Diffs
> -----
>
> plasma/generic/applets/icon/icon.cpp b25e5d6
>
> Diff: http://git.reviewboard.kde.org/r/103435/diff/
>
>
> Testing
> -------
>
> looks good
>
>
> Thanks,
>
> Greg T
>
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/103435/">http://git.reviewboard.kde.org/r/103435/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This review has been \
submitted with commit 246d9bcc81878977d68c3cc030f1b6fd2e28cb87 by Gregor Tätzner to \
branch KDE/4.8.</pre> <br />
<p>- Commit</p>
<br />
<p>On January 10th, 2012, 1:41 p.m., Greg T wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for Plasma.</div>
<div>By Greg T.</div>
<p style="color: grey;"><i>Updated Jan. 10, 2012, 1:41 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">I added a special case so the desktop icon gets a pretty name when you \
drag and drop a link onto your desktop. Additional, a regex strips out the protocol \
(like in firefox)
I'm allowed to commit it?</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">looks good</pre> </td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="http://bugs.kde.org/show_bug.cgi?id=199811">199811</a>
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>plasma/generic/applets/icon/icon.cpp <span style="color: \
grey">(b25e5d6)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/103435/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic