--===============1553012415382192008== Content-Type: multipart/alternative; boundary="===============3208032223564483919==" --===============3208032223564483919== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable > On March 28, 2012, 6:06 p.m., Marco Martin wrote: > > to me the blocker is mostly having to have kmix running... > > since actual kmix would be (sill ;) needed for the actual complete ui..= . what about this? > > = > > a modification in the systray applet, that queries sycoca for offers of= plasmoids that can manage a determined statusnotifier item, so it would as= k for something providing KMix (better if the ksni id is renamed in org.kde= .kmix) then will be the systray itself that either instantiates the kmix ap= plet, or just doesn't show the kmix icon if the applet was explicitly creat= ed by the user. > > = > > idea is still a bit nebulous, did i explain myself enough? ;) > = > Diego Casella wrote: > From a quick look of the code, there's the chance to build the daemon= too.. If so, there's no need to do all that work :) > About the need of the complete UI, we need it only for one purpose: s= elect which channel will be the Master channel. I can't list all the availa= ble channels inside the standard config page (the one which appears when yo= u click on the wrench icon in the applet handle), because of scripted plasm= oid limitiations. But, thanks to the awesome progress made with plasmacompo= nents, I could use your fancy Dialog item to show all the channels availabl= e, and allow the user to choose which one will be the Master channel :) > In this way, we could drop the KMix windowed app, keep only the daemo= n, and talk to it with one (or more) kmix applet. What do you think? I think the windowed app will still be needed, since we ain't going to show= all the sliders in the applet (it will be a complete mess). There may be f= ew sliders users don't want to see in applet but still want to control some= times (as for me, for example, capture sliders). Daemonizing is a good idea= , but we should think how windowed app should work with it. Also, have you seen my implementation of applet ( http://quickgit.kde.org/i= ndex.php?p=3Dscratch%2Fpoboiko%2Fkmix-plasmoid.git&a=3Dtree )? It isn't dec= larative, but it has more features (since it hasn't limitations scripted pl= asmoids have). - Igor ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://svn.reviewboard.kde.org/r/6928/#review10739 ----------------------------------------------------------- On March 28, 2012, 6:49 p.m., Diego Casella wrote: > = > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://svn.reviewboard.kde.org/r/6928/ > ----------------------------------------------------------- > = > (Updated March 28, 2012, 6:49 p.m.) > = > = > Review request for Plasma, Aaron Seigo, Marco Martin, and Christian Esken. > = > = > Description > ------- > = > First attempt of making a declarative kmix applet for plasma. > What the apple does right now: > * modifies the volume level and the mute/unmute status of the master chan= nel; > * reacts to changes of the volume level/status (i.e. made with multimedia= keys); > * disables the slider if the channel gets muted, and enables it back as s= oon as the channel gets unmuted; > * collapses gracefully in a popup icon when placed inside the panel. > = > = > Diffs > ----- > = > trunk/KDE/kdemultimedia/kmix/plasma/CMakeLists.txt 1287513 = > trunk/KDE/kdemultimedia/kmix/plasma/kmix-applet/contents/code/VerticalC= ontrol.qml PRE-CREATION = > trunk/KDE/kdemultimedia/kmix/plasma/kmix-applet/contents/code/kmixapple= t.qml PRE-CREATION = > trunk/KDE/kdemultimedia/kmix/plasma/kmix-applet/metadata.desktop PRE-CR= EATION = > = > Diff: http://svn.reviewboard.kde.org/r/6928/diff/ > = > = > Testing > ------- > = > Tested against r1287510. For basic audio management it works great imho. > = > However, there is a lot of room for improvements, but this is gonna need = some extra work outside the kmix applet scope: > * first of all, the applet need kmix executable to run in order to perfor= m the dbus calls. You can of course disable KMix tray icon feature but, at = every login, KMix mainwindow will be shown and the user must closeby hand. = This is a kind of ugly behavior that should be avoided; > * it will be great to great to add an action to allow the user to select = the master channel (by reusing KMix "Select Master Channel" widget), but th= is will require tweaking KMix dbus interface; > * as you noticed in the screenshots, the applet in the panel and in the d= esktop have different size even if it __is__ actually the same: something i= s going wrong when plasma shows the PopupApplet. This behavior was even wor= se when I started implementing a "flip" action to change the layout from ho= rizontal to vertical and vice-versa, and for this reason I gave up and simp= ly stick with the vertical layout. > = > Could this applet be shipped in the current status, or should we wait for= all the aforementioned improvements? > Comments/ideas/suggestions? > = > Cheers :) > = > = > Screenshots > ----------- > = > Applet look in panel and desktop > http://svn.reviewboard.kde.org/r/6928/s/627/ > Applet look in panel and desktop - audio muted > http://svn.reviewboard.kde.org/r/6928/s/628/ > = > = > Thanks, > = > Diego Casella > = > --===============3208032223564483919== Content-Type: text/html; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable
This is an automatically generated e-mail. To reply, visit: http://svn.reviewb= oard.kde.org/r/6928/

On March 28th, 2012, 6:06 p.m., Marco Marti= n wrote:

to me the=
 blocker is mostly having to have kmix running...
since actual kmix would be (sill ;) needed for the actual complete ui... wh=
at about this?

a modification in the systray applet, that queries sycoca for offers of pla=
smoids that can manage a determined statusnotifier item, so it would ask fo=
r something providing KMix (better if the ksni id is renamed in org.kde.kmi=
x) then will be the systray itself that either instantiates the kmix applet=
, or just doesn't show the kmix icon if the applet was explicitly creat=
ed by the user.

idea is still a bit nebulous, did i explain myself enough? ;)

On March 28th, 2012, 7:42 p.m., Diego Casella wrote:

From a qu=
ick look of the code, there's the chance to build the daemon too.. If s=
o, there's no need to do all that work :)
About the need of the complete UI, we need it only for one purpose: select =
which channel will be the Master channel. I can't list all the availabl=
e channels inside the standard config page (the one which appears when you =
click on the wrench icon in the applet handle), because of scripted plasmoi=
d limitiations. But, thanks to the awesome progress made with plasmacompone=
nts, I could use your fancy Dialog item to show all the channels available,=
 and allow the user to choose which one will be the Master channel :)
In this way, we could drop the KMix windowed app, keep only the daemon, and=
 talk to it with one (or more) kmix applet. What do you think? 
I think the=
 windowed app will still be needed, since we ain't going to show all th=
e sliders in the applet (it will be a complete mess). There may be few slid=
ers users don't want to see in applet but still want to control sometim=
es (as for me, for example, capture sliders). Daemonizing is a good idea, b=
ut we should think how windowed app should work with it.
Also, have you seen my implementation of applet ( http://quickgit.kde.org/i=
ndex.php?p=3Dscratch%2Fpoboiko%2Fkmix-plasmoid.git&a=3Dtree )? It isn&#=
39;t declarative, but it has more features (since it hasn't limitations=
 scripted plasmoids have).

- Igor


On March 28th, 2012, 6:49 p.m., Diego Casella wrote:

Review request for Plasma, Aaron Seigo, Marco Martin, and Christian Es= ken.
By Diego Casella.

Updated March 28, 2012, 6:49 p.m.

Descripti= on 

First attempt of making a declarative kmix applet for plasma.
What the apple does right now:
* modifies the volume level and the mute/unmute status of the master channe=
l;
* reacts to changes of the volume level/status (i.e. made with multimedia k=
eys);
* disables the slider if the channel gets muted, and enables it back as soo=
n as the channel gets unmuted;
* collapses gracefully in a popup icon when placed inside the panel.

Testing <= /h1> 
Tested against r1287510. For basic audio management it works=
 great imho.

However, there is a lot of room for improvements, but this is gonna need so=
me extra work outside the kmix applet scope:
* first of all, the applet need kmix executable to run in order to perform =
the dbus calls. You can of course disable KMix tray icon feature but, at ev=
ery login, KMix mainwindow will be shown and the user must closeby hand. Th=
is is a kind of ugly behavior that should be avoided;
* it will be great to great to add an action to allow the user to select th=
e master channel (by reusing KMix "Select Master Channel" widget)=
, but this will require tweaking KMix dbus interface;
* as you noticed in the screenshots, the applet in the panel and in the des=
ktop have different size even if it __is__ actually the same: something is =
going wrong when plasma shows the PopupApplet. This behavior was even worse=
 when I started implementing a "flip" action to change the layout=
 from horizontal to vertical and vice-versa, and for this reason I gave up =
and simply stick with the vertical layout.

Could this applet be shipped in the current status, or should we wait for a=
ll the aforementioned improvements?
Comments/ideas/suggestions?

Cheers :)

Diffs=

  • trunk/KDE/kdemultimedia/kmix/plasma/CMakeLists.txt (1287513)
  • trunk/KDE/kdemultimedia/kmix/plasma/kmix-applet/contents/code/Vertical= Control.qml (PRE-CREATION)
  • trunk/KDE/kdemultimedia/kmix/plasma/kmix-applet/contents/code/kmixappl= et.qml (PRE-CREATION)
  • trunk/KDE/kdemultimedia/kmix/plasma/kmix-applet/metadata.desktop (PRE-CREATION)

View Diff

Screensho= ts

3D"Applet 3D"Applet
--===============3208032223564483919==-- --===============1553012415382192008== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel --===============1553012415382192008==--