From kde-panel-devel Tue Apr 17 11:22:22 2012 From: "Viranch Mehta" Date: Tue, 17 Apr 2012 11:22:22 +0000 To: kde-panel-devel Subject: Re: Review Request: Merge the final and fixed QML battery monitor to master. Message-Id: <20120417112222.6737.79748 () vidsolbach ! de> X-MARC-Message: https://marc.info/?l=kde-panel-devel&m=133466186809210 MIME-Version: 1 Content-Type: multipart/mixed; boundary="--===============4875006727251397747==" --===============4875006727251397747== Content-Type: multipart/alternative; boundary="===============5736501406562363648==" --===============5736501406562363648== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable > On April 17, 2012, 11:18 a.m., Kai Uwe Broulik wrote: > > I just applied it to latest master and found a few usability issues: > > * The settings dialog that contains all the configs is way too small > > * The slider "grab" is 10 pixels to the left, some QML component issue > > And the showstopper issue is: > > There is no easy way to see the battery percentage. The overlay number = is no longer available. And also there is no tooltip, i.e. hovering the pla= smoid also does nothing. You _always_ have to click the battery plasmoid to= see the exact percentage. > > The tooltip thing seems to be a general QML plasmoid issue, the new dev= icec notifier also lacks one. The patch is not up-to-date. Please checkout the branch plasma/viranch/powe= rmanagementservices and compile plasma/generic/{applets/batterymonitor,data= engines/powermanagement}. That's where all my latest commits have gone. - Viranch ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104226/#review12560 ----------------------------------------------------------- On April 3, 2012, 5:12 a.m., Viranch Mehta wrote: > = > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/104226/ > ----------------------------------------------------------- > = > (Updated April 3, 2012, 5:12 a.m.) > = > = > Review request for Plasma. > = > = > Description > ------- > = > I fixed the QML battery monitor to be fairly usable and this diff merges = it to master. > = > = > Diffs > ----- > = > plasma/generic/applets/CMakeLists.txt 2dedcb2 = > plasma/generic/applets/batterymonitor/CMakeLists.txt PRE-CREATION = > plasma/generic/applets/batterymonitor/Messages.sh PRE-CREATION = > plasma/generic/applets/batterymonitor/README.txt PRE-CREATION = > plasma/generic/applets/batterymonitor/battery-oxygen-inkscape.svgz PRE-= CREATION = > plasma/generic/applets/batterymonitor/battery-oxygen.svgz PRE-CREATION = > plasma/generic/applets/batterymonitor/contents/config/main.xml PRE-CREA= TION = > plasma/generic/applets/batterymonitor/contents/ui/IconButton.qml PRE-CR= EATION = > plasma/generic/applets/batterymonitor/contents/ui/PopupDialog.qml PRE-C= REATION = > plasma/generic/applets/batterymonitor/contents/ui/batterymonitor.qml PR= E-CREATION = > plasma/generic/applets/batterymonitor/contents/ui/config.ui PRE-CREATIO= N = > plasma/generic/applets/batterymonitor/metadata.desktop PRE-CREATION = > plasma/generic/dataengines/powermanagement/powermanagementengine.h 2064= 2c2 = > plasma/generic/dataengines/powermanagement/powermanagementengine.cpp 55= 72fcb = > plasma/generic/dataengines/powermanagement/powermanagementjob.h 2c32015 = > plasma/generic/dataengines/powermanagement/powermanagementjob.cpp e205b= b0 = > plasma/generic/dataengines/powermanagement/powermanagementservice.opera= tions ad1301f = > = > Diff: http://git.reviewboard.kde.org/r/104226/diff/ > = > = > Testing > ------- > = > Applet and dataengine both tested and work fine. > = > = > Screenshots > ----------- > = > with top right graphic in the popup > http://git.reviewboard.kde.org/r/104226/s/487/ > applet on the workspace > http://git.reviewboard.kde.org/r/104226/s/503/ > = > = > Thanks, > = > Viranch Mehta > = > --===============5736501406562363648== Content-Type: text/html; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable
This is an automatically generated e-mail. To reply, visit: http://git.revie= wboard.kde.org/r/104226/

On April 17th, 2012, 11:18 a.m., Kai Uwe Br= oulik wrote:

I just ap=
plied it to latest master and found a few usability issues:
* The settings dialog that contains all the configs is way too small
* The slider "grab" is 10 pixels to the left, some QML component =
issue
And the showstopper issue is:
There is no easy way to see the battery percentage. The overlay number is n=
o longer available. And also there is no tooltip, i.e. hovering the plasmoi=
d also does nothing. You _always_ have to click the battery plasmoid to see=
 the exact percentage.
The tooltip thing seems to be a general QML plasmoid issue, the new devicec=
 notifier also lacks one.
The patch i=
s not up-to-date. Please checkout the branch plasma/viranch/powermanagement=
services and compile plasma/generic/{applets/batterymonitor,dataengines/pow=
ermanagement}. That's where all my latest commits have gone.

- Viranch


On April 3rd, 2012, 5:12 a.m., Viranch Mehta wrote:

Review request for Plasma.
By Viranch Mehta.

Updated April 3, 2012, 5:12 a.m.

Descripti= on 

I fixed the QML battery monitor to be fairly usable and this=
 diff merges it to master.

Testing <= /h1> 
Applet and dataengine both tested and work fine.

Diffs=

  • plasma/generic/applets/CMakeLists.txt (2de= dcb2)
  • plasma/generic/applets/batterymonitor/CMakeLists.txt (PRE-CREATION)
  • plasma/generic/applets/batterymonitor/Messages.sh (PRE-CREATION)
  • plasma/generic/applets/batterymonitor/README.txt (PRE-CREATION)
  • plasma/generic/applets/batterymonitor/battery-oxygen-inkscape.svgz (PRE-CREATION)
  • plasma/generic/applets/batterymonitor/battery-oxygen.svgz (PRE-CREATION)
  • plasma/generic/applets/batterymonitor/contents/config/main.xml (PRE-CREATION)
  • plasma/generic/applets/batterymonitor/contents/ui/IconButton.qml (PRE-CREATION)
  • plasma/generic/applets/batterymonitor/contents/ui/PopupDialog.qml (PRE-CREATION)
  • plasma/generic/applets/batterymonitor/contents/ui/batterymonitor.qml <= span style=3D"color: grey">(PRE-CREATION)
  • plasma/generic/applets/batterymonitor/contents/ui/config.ui (PRE-CREATION)
  • plasma/generic/applets/batterymonitor/metadata.desktop (PRE-CREATION)
  • plasma/generic/dataengines/powermanagement/powermanagementengine.h (20642c2)
  • plasma/generic/dataengines/powermanagement/powermanagementengine.cpp <= span style=3D"color: grey">(5572fcb)
  • plasma/generic/dataengines/powermanagement/powermanagementjob.h (2c32015)
  • plasma/generic/dataengines/powermanagement/powermanagementjob.cpp (e205bb0)
  • plasma/generic/dataengines/powermanagement/powermanagementservice.oper= ations (ad1301f)

View Diff

Screensho= ts

3D"with 3D"applet
--===============5736501406562363648==-- --===============4875006727251397747== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel --===============4875006727251397747==--