From kde-panel-devel Sun Apr 15 15:18:54 2012 From: "Commit Hook" Date: Sun, 15 Apr 2012 15:18:54 +0000 To: kde-panel-devel Subject: Re: Review Request: GlobalShortcuts Plugin for ActivityManager (kamd) Message-Id: <20120415151854.19026.90565 () vidsolbach ! de> X-MARC-Message: https://marc.info/?l=kde-panel-devel&m=133453701729140 MIME-Version: 1 Content-Type: multipart/mixed; boundary="--===============6405092938681919486==" --===============6405092938681919486== Content-Type: multipart/alternative; boundary="===============1359476751090163909==" --===============1359476751090163909== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104428/#review12477 ----------------------------------------------------------- This review has been submitted with commit 7e2ef3c7f0a6584a040b4fe70e1012de= 9b1511d8 by Makis Marimpis to branch master. - Commit Hook On April 12, 2012, 8:23 a.m., makis marimpis wrote: > = > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/104428/ > ----------------------------------------------------------- > = > (Updated April 12, 2012, 8:23 a.m.) > = > = > Review request for KDE Base Apps, KDE Runtime, Plasma, and Ivan =C4=8Cuki= =C4=87. > = > = > Description > ------- > = > (follows discarded review: 104391) > = > The plugin adds global keyboard shortcuts for changing the activity. > Defaults start from Qt::MetaModifier + Qt::Key_F1. > = > Initially, this functionality was implemented (without correct results) u= sing KActitivities::Controller. > Using DBus seems fine, just that... it forces kamd to start with 3-4 seco= nds delay - so it really needs modification/and i would like more guidance = related to dbus :D. > Other than that, feedback is needed. = > = > = > This addresses bugs 265069 and 273467. > http://bugs.kde.org/show_bug.cgi?id=3D265069 > http://bugs.kde.org/show_bug.cgi?id=3D273467 > = > = > Diffs > ----- > = > service/plugins/CMakeLists.txt 3e965c0a201a7eee2c9868fcf163cf55af636858 = > service/plugins/globalshortcuts/CMakeLists.txt PRE-CREATION = > service/plugins/globalshortcuts/activitymanager-plugin-globalshortcuts.= desktop PRE-CREATION = > service/plugins/globalshortcuts/globalshortcuts.h PRE-CREATION = > service/plugins/globalshortcuts/globalshortcuts.cpp PRE-CREATION = > = > Diff: http://git.reviewboard.kde.org/r/104428/diff/ > = > = > Testing > ------- > = > Logged in. > Used the default shortcuts to switch activities. > It works! > = > = > Thanks, > = > makis marimpis > = > --===============1359476751090163909== Content-Type: text/html; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable
This is an automatically generated e-mail. To reply, visit: http://git.revie= wboard.kde.org/r/104428/ 

This revie=
w has been submitted with commit 7e2ef3c7f0a6584a040b4fe70e1012de9b1511d8 b=
y Makis Marimpis to branch master.

- Commit


On April 12th, 2012, 8:23 a.m., makis marimpis wrote:

Review request for KDE Base Apps, KDE Runtime, Plasma, and Ivan =C4=8C= uki=C4=87.
By makis marimpis.

Updated April 12, 2012, 8:23 a.m.

Descripti= on 

(follows discarded review: 104391)

The plugin adds global keyboard shortcuts for changing the activity.
Defaults start from Qt::MetaModifier + Qt::Key_F1.

Initially, this functionality was implemented (without correct results) usi=
ng KActitivities::Controller.
Using DBus seems fine, just that... it forces kamd to start with 3-4 second=
s delay - so it really needs modification/and i would like more guidance re=
lated to dbus :D.
Other than that, feedback is needed.

Testing <= /h1> 
Logged in.
Used the default shortcuts to switch activities.
It works!
Bugs: 265069, = 273467

Diffs=

  • service/plugins/CMakeLists.txt (3e965c0a20= 1a7eee2c9868fcf163cf55af636858)
  • service/plugins/globalshortcuts/CMakeLists.txt (PRE-CREATION)
  • service/plugins/globalshortcuts/activitymanager-plugin-globalshortcuts= .desktop (PRE-CREATION)
  • service/plugins/globalshortcuts/globalshortcuts.h (PRE-CREATION)
  • service/plugins/globalshortcuts/globalshortcuts.cpp (PRE-CREATION)

View Diff
--===============1359476751090163909==-- --===============6405092938681919486== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel --===============6405092938681919486==--