From kde-panel-devel Sat Apr 14 14:10:06 2012 From: "Commit Hook" Date: Sat, 14 Apr 2012 14:10:06 +0000 To: kde-panel-devel Subject: Re: Review Request: Misc minor fixes in KRunner. Message-Id: <20120414141006.8803.91694 () vidsolbach ! de> X-MARC-Message: https://marc.info/?l=kde-panel-devel&m=133441273028478 MIME-Version: 1 Content-Type: multipart/mixed; boundary="--===============8871245536775633718==" --===============8871245536775633718== Content-Type: multipart/alternative; boundary="===============0800076578511904740==" --===============0800076578511904740== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104431/#review12430 ----------------------------------------------------------- This review has been submitted with commit 611c461bcf3687d02a9b1078f1451bc7= f81bdd94 by David Edmundson to branch master. - Commit Hook On April 6, 2012, 10:20 p.m., David Edmundson wrote: > = > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/104431/ > ----------------------------------------------------------- > = > (Updated April 6, 2012, 10:20 p.m.) > = > = > Review request for Plasma. > = > = > Description > ------- > = > * Remove "runner" from "Nepomuk Desktop Search Runner" as the runner is i= mplied from the context and to bring consistency. > * Add correct icon for activities runner > * Use correct case in description of "places" runner. > * Use correct case in Webshorts runner description > * Match top and bottom margin sizes. This updates a bodge that removed 2 = pixels from the top margin to only use 1. > * Reword "Available Features" to "Available Plugins" for consistency > * Make the krunner config dialog appear to load slightly faster by loadin= g the list of plugins after we've shown the dialog. > * Remove undefined (and unused) private method. > = > = > Diffs > ----- > = > krunner/configdialog.h a9c353a = > krunner/configdialog.cpp 80485ca = > krunner/krunnerdialog.cpp 007887f = > plasma/generic/runners/activities/plasma-runner-activityrunner.desktop = 853c680 = > plasma/generic/runners/nepomuksearch/plasma-runner-nepomuksearch.deskto= p 0319463 = > plasma/generic/runners/places/plasma-runner-places.desktop b82fa14 = > plasma/generic/runners/webshortcuts/plasma-runner-webshortcuts.desktop = f234b4f = > = > Diff: http://git.reviewboard.kde.org/r/104431/diff/ > = > = > Testing > ------- > = > = > Thanks, > = > David Edmundson > = > --===============0800076578511904740== Content-Type: text/html; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable
This is an automatically generated e-mail. To reply, visit: http://git.revie= wboard.kde.org/r/104431/ 

This revie=
w has been submitted with commit 611c461bcf3687d02a9b1078f1451bc7f81bdd94 b=
y David Edmundson to branch master.

- Commit


On April 6th, 2012, 10:20 p.m., David Edmundson wrote:

Review request for Plasma.
By David Edmundson.

Updated April 6, 2012, 10:20 p.m.

Descripti= on 

* Remove "runner" from "Nepomuk Desktop Searc=
h Runner" as the runner is implied from the context and to bring consi=
stency.
* Add correct icon for activities runner
* Use correct case in description of "places" runner.
* Use correct case in Webshorts runner description
* Match top and bottom margin sizes. This updates a bodge that removed 2 pi=
xels from the top margin to only use 1.
* Reword "Available Features" to "Available Plugins" fo=
r consistency
* Make the krunner config dialog appear to load slightly faster by loading =
the list of plugins after we've shown the dialog.
* Remove undefined (and unused) private method.

Diffs=

  • krunner/configdialog.h (a9c353a)
  • krunner/configdialog.cpp (80485ca)<= /li>
  • krunner/krunnerdialog.cpp (007887f)=
  • plasma/generic/runners/activities/plasma-runner-activityrunner.desktop= (853c680)
  • plasma/generic/runners/nepomuksearch/plasma-runner-nepomuksearch.deskt= op (0319463)
  • plasma/generic/runners/places/plasma-runner-places.desktop (b82fa14)
  • plasma/generic/runners/webshortcuts/plasma-runner-webshortcuts.desktop= (f234b4f)

View Diff
--===============0800076578511904740==-- --===============8871245536775633718== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel --===============8871245536775633718==--