[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-panel-devel
Subject: Re: Review Request: Couple of fixes to QML ScrollBar component
From: "Commit Hook" <null () kde ! org>
Date: 2012-04-04 10:15:35
Message-ID: 20120404101535.14865.1481 () vidsolbach ! de
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104402/#review12156
-----------------------------------------------------------
This review has been submitted with commit 012886da3fa2d4d238646dc684fe3526=
14f19504 by Viranch Mehta to branch master.
- Commit Hook
On March 25, 2012, 2:59 a.m., Viranch Mehta wrote:
> =
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/104402/
> -----------------------------------------------------------
> =
> (Updated March 25, 2012, 2:59 a.m.)
> =
> =
> Review request for Plasma.
> =
> =
> Description
> -------
> =
> This patch fixes following issues with QML Scrollbar component:
> =
> - The hover and non-hover arrow images in vertical scrollbars are the sam=
e.
> - The down/right arrows are connected to events of mousearea of up/left a=
rrows.
> - The mouseareas of the arrows do not have hoverEnabled property set to t=
rue. This is required to use their containsMouse property.
> =
> =
> Diffs
> -----
> =
> plasma/declarativeimports/plasmacomponents/qml/private/ScrollBarDelegat=
e.qml 15ee7aa =
> =
> Diff: http://git.reviewboard.kde.org/r/104402/diff/
> =
> =
> Testing
> -------
> =
> I didn't know how to test these from Gallery.qml (what command?). Tested,=
however, by putting in a test plasmoid. Works well now.
> =
> =
> Thanks,
> =
> Viranch Mehta
> =
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/104402/">http://git.reviewboard.kde.org/r/104402/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This review has been \
submitted with commit 012886da3fa2d4d238646dc684fe352614f19504 by Viranch Mehta to \
branch master.</pre> <br />
<p>- Commit</p>
<br />
<p>On March 25th, 2012, 2:59 a.m., Viranch Mehta wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for Plasma.</div>
<div>By Viranch Mehta.</div>
<p style="color: grey;"><i>Updated March 25, 2012, 2:59 a.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">This patch fixes following issues with QML Scrollbar component:
- The hover and non-hover arrow images in vertical scrollbars are the same.
- The down/right arrows are connected to events of mousearea of up/left arrows.
- The mouseareas of the arrows do not have hoverEnabled property set to true. This is \
required to use their containsMouse property. </pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">I didn't know how to test these from Gallery.qml (what command?). \
Tested, however, by putting in a test plasmoid. Works well now.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>plasma/declarativeimports/plasmacomponents/qml/private/ScrollBarDelegate.qml \
<span style="color: grey">(15ee7aa)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/104402/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic