--===============2776714115462309162== Content-Type: multipart/alternative; boundary="===============2624373051525757835==" --===============2624373051525757835== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable > On March 30, 2012, 8:18 p.m., Thomas L=C3=BCbking wrote: > > service/jobs/nepomuk/Move.cpp, line 352 > > > > > > "!QUrl::isLocalFile()"? > = > Lamarque Vieira Souza wrote: > isLocalFile() was introduced in Qt 4.8.0 and we still use Qt 4.7.4 in= Meego image. > = > Thomas L=C3=BCbking wrote: > Qt doc bogus? > http://qt-project.org/doc/qt-4.8/qurl.html#isLocalFile Yes: http://qt-project.org/doc/note_revisions/137/234/view - Lamarque Vieira ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104417/#review12037 ----------------------------------------------------------- On March 30, 2012, 6:57 p.m., Lamarque Vieira Souza wrote: > = > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/104417/ > ----------------------------------------------------------- > = > (Updated March 30, 2012, 6:57 p.m.) > = > = > Review request for KDE Runtime and Plasma. > = > = > Description > ------- > = > When adding an application resource to a private activity kactivitymanage= r tries to move the resource's .desktop file to the activity's private fold= er. The new .desktop file is created successfully but the source file is no= t deleted if the user does not have write permission on the file's director= y. This patch detects such situation and uses copy instead of move to preve= nt "permission denied" messages for every resource being added. > = > = > This addresses bug 296808. > http://bugs.kde.org/show_bug.cgi?id=3D296808 > = > = > Diffs > ----- > = > service/jobs/nepomuk/Move.h 8a8afd1 = > service/jobs/nepomuk/Move.cpp 2248768 = > = > Diff: http://git.reviewboard.kde.org/r/104417/diff/ > = > = > Testing > ------- > = > Works for resources of type "app", it does not work for "image" yet becau= se Move::canMove receives the nepomuk's uri instead of the file url when th= e resource type is "image". > = > = > Thanks, > = > Lamarque Vieira Souza > = > --===============2624373051525757835== Content-Type: text/html; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable
This is an automatically generated e-mail. To reply, visit: http://git.revie= wboard.kde.org/r/104417/

On March 30th, 2012, 8:18 p.m., Thomas L=C3= =BCbking wrote:

= = =
service/jobs/nepomuk/Move.cpp (Diff revision 5) 

   
bool Move::canMove(const QUrl & source)


  

 

  

    
    

    352
    
    if (source.scheme() !=3D=
 QLatin1String("file")) {

  


 




  
"!QU=
rl::isLocalFile()"?

 




 
On March 30th, 2012, 8:40 p.m., Lamarque Vieira Souza wrote:

 

  
isLocalFi=
le() was introduced in Qt 4.8.0 and we still use Qt 4.7.4 in Meego image.
 






 
On March 30th, 2012, 8:45 p.m., Thomas L=C3=BCbking wrote:

 

  
Qt doc bo=
gus?
http://qt-project.org/doc/qt-4.8/qurl.html#isLocalFile

 











Yes: http://qt-project.org/doc/note_revisions/137/234/view








- Lamarque Vieira






On March 30th, 2012, 6:57 p.m., Lamarque Vieira Souza wrote:









 

  


Review request for KDE Runtime and Plasma.


By Lamarque Vieira Souza.




Updated March 30, 2012, 6:57 p.m.








Descripti=
on 

 

 

  
   
When adding an application resource to a private activity ka=
ctivitymanager tries to move the resource's .desktop file to the activi=
ty's private folder. The new .desktop file is created successfully but =
the source file is not deleted if the user does not have write permission o=
n the file's directory. This patch detects such situation and uses copy=
 instead of move to prevent "permission denied" messages for ever=
y resource being added.

  		
 






Testing <=
/h1>


 

  
   
Works for resources of type "app", it does not wor=
k for "image" yet because Move::canMove receives the nepomuk'=
s uri instead of the file url when the resource type is "image".<=
/pre>
  

 








 Bugs: 


 296808







Diffs=
 


    

 
  • service/jobs/nepomuk/Move.h (8a8afd1)
    • 

 
  • service/jobs/nepomuk/Move.cpp (2248768)
    • 





View Diff





  		
 











  

 



--===============2624373051525757835==--

--===============2776714115462309162==
Content-Type: text/plain; charset="us-ascii"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Content-Disposition: inline

_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

--===============2776714115462309162==--